Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run prettier and eslint #3015

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Run prettier and eslint #3015

merged 1 commit into from
Apr 8, 2024

Conversation

mattjennings
Copy link
Contributor

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

see #3014

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Apr 7, 2024
@mattjennings mattjennings mentioned this pull request Apr 7, 2024
Merged
5 tasks
@mattjennings mattjennings added chore Maintenance tasks, like upgrading libraries or release tasks and removed bug This issue describes undesirable, incorrect, or unexpected behavior labels Apr 7, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 8, 2024 •
edited
Loading

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 027fd0a
Status: ✅  Deploy successful!
Preview URL: https://2b599d12.excaliburjs.pages.dev
Branch Preview URL: https://fix-2378-format.excaliburjs.pages.dev

View logs

eonarheim
eonarheim approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjennings :shipit:

@mattjennings mattjennings merged commit 7a41afe into fix/2378 Apr 8, 2024
1 of 2 checks passed
@mattjennings mattjennings deleted the fix/2378-format branch April 8, 2024 02:49
eonarheim pushed a commit that referenced this pull request Apr 8, 2024
@mattjennings
chore: enforce prettier and eslint (#3014)
582fbcc 
See issue #2378 

- Add prettier for code formatting
- Update eslint config to parse other parts of codebase outside of `src/engine`, and also remove rules that are handled by prettier
- Add husky & lint-staged to enforce formatting on git commit
- Add format step to `all` and `all:ci` scripts

I separated the commit that runs the format & lint on all files into #3015 so the config can be easily reviewed here. 

Once we're happy with this, we can merge that PR into this one and ignore the commit(s) using `git blame --ignore-rev` to remove it from git blame history.
@eonarheim eonarheim mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
chore Maintenance tasks, like upgrading libraries or release tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjennings @eonarheim