Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CollisionContact.bias(collider) #3122

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

mattjennings
Copy link
Contributor

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Follow up from #3121

Changes:

  • CollisionContact can be biased toward a collider by using contact.bias(collider). This adjusts the contact so that the given collider is colliderA, and is helpful if you
    are doing mtv adjustments during precollision.

@mattjennings mattjennings changed the title add CollisionContact.bias(collider) feat: add CollisionContact.bias(collider) Jul 7, 2024
@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label Jul 7, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6b4ca2
Status: ✅  Deploy successful!
Preview URL: https://cd297762.excaliburjs.pages.dev
Branch Preview URL: https://feat-contact-bias.excaliburjs.pages.dev

View logs

@eonarheim
Copy link
Member

I've introduced some test flakiness in main, so I'm pretty sure re-running will succeed

@eonarheim eonarheim merged commit e57fd3f into main Jul 8, 2024
7 of 8 checks passed
@eonarheim eonarheim deleted the feat/contact-bias branch July 8, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants