-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPGRADE: Support Sphinx 7 #524
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
d0aa2e2
to
4d47f95
Compare
If you can get all of the tests passing here then I'm happy to take a look and merge. MyST-NB hits a lot of the inner Sphinx machinery and so new Sphinx releases tend to break MyST-NB. The PR with the most activity on getting various versions bumped is here: |
I think it is best to focus on #479 because of Sphinx7 it is mostly dependency issues. I will then rebase on top of that and see what surprises we get from the other CIs. Sounds like a good plan? |
agreed - we need to get this stack upgraded in general and that is a big blocker |
Applied #479 temporarily so we can see the broader tests after that is applied |
Great, everything seems to be working with that branch and in this PR it's only the Sphinx7 dependency issue that I wanted to highlight and address.
jupytext issue is being slowly handled: mwouts/jupytext#1075 |
Jupytext pushed a new version so now all dependencies are satisfied. I restarted rhe CI locally, but found rhat 3.11 is failing |
I've just merged in the MyST-Parser bump, and updated this branch to use it. Just FYI! |
Ok, I'll rebase it. In a sec. Keep an eye out to restart the CI |
Oh, all tests are green on my fork 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot! It looks like it is happy :-)
Thanks for this contribution ✨
Great, anything else before pushing a new tag? |
There is a dependency hell to resolve here due to the testing requirements. However this package is a blocking requirement for various other packages downstream. These test requirements should be addressed.
See my fork's PR for current status LecrisUT#1