Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump markdown-it-py requirements #1075

Closed
LecrisUT opened this issue Jun 17, 2023 · 3 comments · Fixed by #1087
Closed

Bump markdown-it-py requirements #1075

LecrisUT opened this issue Jun 17, 2023 · 3 comments · Fixed by #1087

Comments

@LecrisUT
Copy link
Contributor

Any documented issues for pinning the requirements or markdown-it-py to <3.0.0? Is there a CI for testing the requirement pinnings, especially those in the main dependencies?
@mwouts
Copy link
Owner

mwouts commented Jun 18, 2023

There are no issue that I am aware of. We test the different conversions on a broad collection of notebooks so indeed it would be a great idea to run these tests on the CI with various versions of the dependencies. Would you like to open a PR for that? Thank you

@LecrisUT
Copy link
Contributor Author

Sure, but I can't do the tests locally (missing git module?) and to do it in CI will need #1041 at the very least

@LecrisUT LecrisUT mentioned this issue Jun 23, 2023
Merged
@mwouts mwouts mentioned this issue Jun 24, 2023
Merged
@mwouts
Copy link
Owner

mwouts commented Jun 24, 2023

@LecrisUT , thank you for your help with the github actions! I have prepared a PR at #1087, can you have a look and let me know if that's what you were thinking? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jupytext works with markdown-it-py==3.0 mwouts/jupytext
2 participants
@LecrisUT @mwouts