Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupytext works with markdown-it-py==3.0 #1087

Merged
merged 11 commits into from
Jun 30, 2023
Merged

Jupytext works with markdown-it-py==3.0 #1087

merged 11 commits into from
Jun 30, 2023

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 24, 2023

Fixes #1075

@mwouts mwouts force-pushed the fix_1075 branch 2 times, most recently from 70c24e2 to 93c3b0a Compare June 24, 2023 20:09
setup.py Outdated Show resolved Hide resolved
@LecrisUT
Copy link
Contributor

Let's get these 2 PRs merged (merge #1090 and then rebase just to be safe), and tag a nee release so people don't have to wait on this too long ;)

@LecrisUT
Copy link
Contributor

LecrisUT commented Jun 29, 2023

Why is CI/build being skipped? Maybe it's just not registered yet 🤔

@mwouts
Copy link
Owner Author

mwouts commented Jun 29, 2023

Hey @LecrisUT , sure I can package a new release.

However I am afraid that the test-pip job is now missing on the CI, I bellieve that happened after I moved continue-on-error: ${{ matrix.experimental }} up by one level. Do you see what is wrong here? Thank you.

@LecrisUT
Copy link
Contributor

Let me open in my IDE and see what it reports

@LecrisUT
Copy link
Contributor

LecrisUT commented Jun 29, 2023

Ok, it seems to complain about markdown-it-py-version: null. It seems you would need an empty string there "". The schema only allows: array, boolean, number, object, string, but I think string is the only one that's properly parse-able.

I've also learned a quick trick on the swig project:

test-pip:
  continue-on-error: ${{ matrix.experimental || false }}
  matrix:
    python-version: ["3.10", "3.11"]
    include:
      - python-version: "3.20"
        experimental: true

@mwouts
Copy link
Owner Author

mwouts commented Jun 29, 2023

Ok I see, thanks. I am sorry I have to go, I will try to package the new version tonight. Thanks for your help!

Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor points. Can be handled another time

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved
@mwouts mwouts merged commit 34d3ac0 into main Jun 30, 2023
@mwouts mwouts deleted the fix_1075 branch June 30, 2023 00:13
@mwouts
Copy link
Owner Author

mwouts commented Jun 30, 2023

The new version jupytext==1.14.7 is available on pypi - Published using trusted publishing - I was impressed to see that it worked at the first attempt!! Thank you @LecrisUT for your guidance on this & the GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump markdown-it-py requirements
2 participants