UPDATE: pydata sphinx theme v0.7.1

[ocefpaf]

Hopefully I won't break anything with the test change.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[choldgraf]

Nice! thanks for this :-) one quick thought, I think we can now remove our custom previous/next templating and CSS, since we've now upstreamed that to the pydata theme:

sphinx-book-theme/sphinx_book_theme/_templates/prev-next.html

Lines 1 to 30 in 414e8bd

	{# Define macro for re-use #}
	{% macro prev_next(prev, next, prev_title='', next_title='') %}
	{%- if prev %}
	<div id="prev">
	<a class="left-prev" href="{{ prev.link|e }}" title="{{ _('previous') }} {{ _('page') }}">
	<i class="prevnext-label fas fa-angle-left"></i>
	<div class="prevnext-info">
	<p class="prevnext-label">{{ _("previous") }}</p>
	<p class="prevnext-title">{{ prev_title or prev.title }}</p>
	</div>
	</a>
	</div>
	{%- endif %}
	{%- if next %}
	<div id="next">
	<a class="right-next" href="{{ next.link|e }}" title="{{ _('next') }} {{ _('page') }}">
	<div class="prevnext-info">
	<p class="prevnext-label">{{ _("next") }}</p>
	<p class="prevnext-title">{{ next_title or next.title }}</p>
	</div>
	<i class="prevnext-label fas fa-angle-right"></i>
	</a>
	</div>
	{%- endif %}
	{% endmacro %}
	{# Add previous / next buttons to page #}
	<div class='prev-next-bottom'>
	{{ prev_next(prev, next) }}
	</div>

any interest in trying that out as part of this?

[ocefpaf]

any interest in trying that out as part of this?

Deleting code? YES! That is my favorite black hole to fall into. I'll report back if I crash and burn in the process.

[chrisjsewell]

think we can now remove our custom previous/next templating and CSS

To check, does it do translations?

[ocefpaf]

BTW, can I get a hacktoberfest-accepted label ;-p

[choldgraf]

@chrisjsewell good catch, it looks like the original PR got modified before it was merged and the code needs tweaking. Will make a PR:

pydata/pydata-sphinx-theme#486

@ocefpaf label applied :-) though note we should not merge this PR until a new PyData theme is released, if we wish to make the templating changes in this PR

[ocefpaf]

if we wish to make the templating changes in this PR

That is up to you. Should I revert the last commit or wait?

[choldgraf]

I think it's fine so long as we don't merge the PR. We can cut a new release on the pydata theme quickly so i think we can just get this one ready to go

[choldgraf]

I've just released a new version of the pydata theme (0.7.1) and bumped the patch version here. Let's see how it builds

[choldgraf]

The prev/next buttons look great! But, I have also noticed some other regressions. For example, see the margin content block:

I don't think we're inheriting that from the pydata theme directly, but seem to be getting it from sphinx basic.css file. Here's the CSS:

div.sidebar, aside.sidebar {
    margin: 0 0 0.5em 1em;
    border: 1px solid #ddb;
    padding: 7px;
    background-color: #ffe;
    width: 40%;
    float: right;
    clear: right;
    overflow-x: auto;
}

@ocefpaf wanna try just adding some CSS to remove that yellow background? And then we should do a quick look over the kitchen sink docs to make sure nothing else has changed unexpectedly

[ocefpaf]

@ocefpaf wanna try just adding some CSS to remove that yellow background? And then we should do a quick look over the kitchen sink docs to make sure nothing else has changed unexpectedly

I'm definitely out of my environment for that change. I'll probably just break it more. Sorry but CSS is a mystery to me.

[choldgraf]

Sounds good @ocefpaf - if you don't mind I'll push to this branch and we can merge it together

[ocefpaf]

Sounds good @ocefpaf - if you don't mind I'll push to this branch and we can merge it together

Not at all. Push all the commits you need.

[ocefpaf]

Oops. Conflicts :-/

[choldgraf]

OK I think it looks correct now, but to give ourselves some time I just cut a release of the theme, and that should give a bit of extra time to make sure nothing is unexpectedly broken.

many thanks @ocefpaf for the contribution :-)

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️