Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing prevnext translations #486

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Conversation

choldgraf
Copy link
Collaborator

In #473 we missed a few things that are needed for translations. This PR makes a few minor edits so that translations work:

  • Words are separated, because sphinx compares translated words against a dictionary of words it knows how to translate, and it doesn't generally understand phrases, only words.
  • Capitalization is done with CSS instead of hard-coded, because sphinx doesn't know how to translated capitalized words.

@jorisvandenbossche
Copy link
Member

Looks good! Feel free to make a 0.7.1 if needed

@choldgraf choldgraf merged commit 0133120 into pydata:master Oct 2, 2021
@choldgraf choldgraf deleted the prevnext-fix branch October 2, 2021 17:44
@choldgraf
Copy link
Collaborator Author

just tried this locally and it worked as expected! merging and will cut a release

matthewevans pushed a commit to aptech/pydata-sphinx-theme that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants