Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protein-translation #957

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add protein-translation #957

merged 1 commit into from
Feb 15, 2024

Conversation

ryanplusplus
Copy link
Member

Related to #940

Note that protein-translation is the #48in24 exercise for next week, so I'd like to get this in prior to Tuesday, Feb. 13th if possible.

@ryanplusplus ryanplusplus requested a review from wolf99 February 8, 2024 00:31
@ryanplusplus ryanplusplus mentioned this pull request Feb 8, 2024
12 tasks
@ryanplusplus
Copy link
Member Author

@siebenschlaefer would you mind taking a look at this?

@siebenschlaefer
Copy link
Contributor

@siebenschlaefer would you mind taking a look at this?

Looks great!
I've checked the stubs, the example solution, the translation of the canonical data to the tests, the config.json, and whether all uuids of the canonical data appear in tests.toml.
I found no issues or code smells whatsoever.

@ryanplusplus
Copy link
Member Author

Looks great! I've checked the stubs, the example solution, the translation of the canonical data to the tests, the config.json, and whether all uuids of the canonical data appear in tests.toml. I found no issues or code smells whatsoever.

Thank you!

@ryanplusplus ryanplusplus merged commit 8f30281 into main Feb 15, 2024
5 checks passed
@ryanplusplus ryanplusplus deleted the protein-translation branch February 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants