key-comparison maze of arrays unclear test of identity or internal structure

[driftsignal]

the equality test for maze of arrays appears to test for identity.

key-comparison-test.lisp line 115-118:

    (:room-arrays
      . (((,+an-array+ ,+a-similar-but-different-array+) . explosion)
      ((,+an-array+ ,+an-array+) . victory)))

the readme suggests internal comparison:

6. The maze of arrays

This maze is simpler with only two rooms. The first needs a key that checks if the arrays contain the equal contents. The second needs a key that is more flexible about checking equality of numbers.

For example:

a                        ; => #[13 23]
b                        ; => #[13 23.0]

(key-arrays a b)         ; => NIL
(key-arrays-loosely a b) ; => T

because a permissive equality predicate will not consider numeric type when comparing the contents of an array.

would it make sense for the readme or the tests be updated to mirror each other?

[github-actions]

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

[verdammelt]

Thanks for reporting this - I will check it out.

[verdammelt]

@driftsignal I updated the test data and instructions to hopefully remove the possible confusion. Please review #803 and let me know if you think it corrects this problem.