Clarify array equality #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `+an-array+` and `+a-similar-but-different-array+` *looking* like the same array led to the possible misconception that anything other than `equalp` would work `eq`, `eql` and `equal` all treat arrays as equal only if they `eq`. `equalp` treat arrays as equal if they are of the same size and their elements are `equalp`. So only `equalp` would work since `+an-array+` and `+a-similar-but-different-array+` were not `eq` even though they looked the same. Making them *more* dissimilar removes the possible confusion.
verdammelt
force-pushed
the
improve-equality-concept-exercise
branch
from
a2fcbaa
to
56199c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test data and instructions could have led to confusion.
The previous instructions and code could lead someone to believe that an equality predicate other than
equalpcould work for the "loosely" function. However even with the previous test data that could not be since all equality predicates butequalponly consider arrays equal if they areeq. Onlyequalpchecks the contents of the array for equality.The mention of numeric type (and then not showing it in the test) was an unintentional red herring.
Both the test data and the instructions have been changed to (hopefully) make things clearer.
Fixes #798
[no important files changed]