-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: Does not produce a tests.toml
file for grains
#39
Comments
Ah yes, that is correct. Should have remembered to fix that, doh! I've actually created an issue on the Nim repo for this. What we should (pending a fix in Nim itself) is probably to just do a text-replace to "correct" the value to one that Nim can handle (maybe use a float?). |
When this is fixed, a PR should be sent to the various tracks to add the missing |
ee7
added a commit
to ee7/exercism-configlet
that referenced
this issue
Oct 13, 2020
Previously, the tool did not create a `tests.toml` file for `grains`. Fixes: exercism#39
ee7
added a commit
to ee7/exercism-configlet
that referenced
this issue
Oct 13, 2020
Previously, the tool did not create a `tests.toml` file for `grains`. Fixes: exercism#39
ErikSchierboom
pushed a commit
that referenced
this issue
Oct 13, 2020
Previously, the tool did not create a `tests.toml` file for `grains`. Fixes: #39
ee7
added a commit
to ee7/exercism-configlet
that referenced
this issue
Jan 21, 2021
Previously, the tool did not create a `tests.toml` file for `grains`. Fixes: exercism#39
ee7
changed the title
Sync: Program does not produce a toml file for
sync: Does not produce a May 10, 2021
grains
tests.toml
file for grains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example
On a track that contains the
grains
exercise, but lacks aexercises/grains/.meta/tests.toml
file, run:Current behaviour
The program does not create a
tests.toml
file forgrains
, but we seeExpected behaviour
The program should create a
tests.toml
file forgrains
.The expected contents are:
Discussion
The cause is here:
https://github.com/exercism/canonical-data-syncer/blob/6e162f70b6944e87ffc2ae60314c38f06459541d/src/probspecs.nim#L80-L84
I remember running into this problem myself. It's because
grains
contains two test cases with large numbers (here and here).The first number is one larger than we can store in a 64-bit signed integer, so it causes an error (and the second number is the maximum that can be stored in a 64-bit unsigned integer).
The text was updated successfully, but these errors were encountered: