Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add support for the grains exercise #42

Merged

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Oct 13, 2020

Previously, the tool did not create a tests.toml file for grains.

This PR is ugly, but it works as a hotfix.

Note that users will see the large numbers in scientific notation:

The following test case is missing:"
{
  "uuid": "c73b470a-5efb-4d53-9ac6-c5f6487f227b",
  "description": "64",
  "property": "square",
  "input": {
    "square": 64
  },
  "expected": 9.223372036854776e+16
}:

Do you want to include the test case ([y]es/[n]o/[s]kip)?:

and

The following test case is missing:"
{
  "uuid": "6eb07385-3659-4b45-a6be-9dc474222750",
  "description": "returns the total number of grains on the board",
  "property": "total",
  "input": {},
  "expected": 1.844674407370955e+17
}:

Do you want to include the test case ([y]es/[n]o/[s]kip)?:

Fixes: #39

@ee7 ee7 requested a review from ErikSchierboom as a code owner October 13, 2020 09:19
Previously, the tool did not create a `tests.toml` file for `grains`.

Fixes: exercism#39
@ee7 ee7 force-pushed the fix-grains-missing-tests-toml-file branch from 80e3a46 to eeac4a7 Compare October 13, 2020 09:41
@ErikSchierboom ErikSchierboom merged commit dbaca97 into exercism:master Oct 13, 2020
@ee7 ee7 deleted the fix-grains-missing-tests-toml-file branch October 13, 2020 09:45
ee7 added a commit to ee7/exercism-configlet that referenced this pull request Jan 21, 2021
Previously, the tool did not create a `tests.toml` file for `grains`.

Fixes: exercism#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync: Does not produce a tests.toml file for grains
2 participants