Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anagram - modify test cases #297

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Conversation

marko213
Copy link
Contributor

@marko213 marko213 commented Jul 14, 2019

This should no longer allow weird solutions where the entire input is rejected if some of the anagram / original word input strings have different case to pass.

Original solution where this was noted: https://exercism.io/mentor/solutions/e4f49b89e76042c9b82544bcfca04929

@marko213
Copy link
Contributor Author

This should probably not be merged until exercism/problem-specifications#1552 is merged.

@marko213 marko213 changed the title Anagram - modify test cases [WIP] Anagram - modify test cases Jul 14, 2019
@marko213
Copy link
Contributor Author

marko213 commented Jul 14, 2019

That PR is merged and the tests created - ready for merging by me.

@marko213 marko213 force-pushed the anagram-test-patch branch from b4bccf2 to 35a91cd Compare July 15, 2019 18:57
@marko213 marko213 changed the title [WIP] Anagram - modify test cases Anagram - modify test cases Jul 15, 2019
Adds two test cases for differently cased words.
@marko213 marko213 force-pushed the anagram-test-patch branch from 35a91cd to ff1357f Compare July 15, 2019 19:18
@marko213
Copy link
Contributor Author

... just after I fix up the branches. Hopefully it's good now.

@arcuru arcuru merged commit c249275 into exercism:master Jul 20, 2019
@arcuru
Copy link
Contributor

arcuru commented Jul 20, 2019

Thanks!

@marko213 marko213 deleted the anagram-test-patch branch July 20, 2019 15:24
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Sep 1, 2019
Add two test cases to catch some weird solutions where all words are
rejected if the matched words have different case.

exercism/cpp#297
exercism/problem-specifications#1552
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Sep 1, 2019
Add two test cases to catch some weird solutions where all words are
rejected if the matched words have different case.

exercism/cpp#297
exercism/problem-specifications#1552
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Sep 1, 2019
Add two test cases to catch some weird solutions where all words are
rejected if the matched words have different case.

exercism/cpp#297
exercism/problem-specifications#1552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants