Anagram - add test cases for differently-cased words #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotp
reviewed
Jul 14, 2019
|
The pull request description has a good description because it describes the reason for the change. The description should be included in the commit message as well; otherwise the commit message only says "modify test cases" which is not helpful for understanding at all. |
Add two test cases to catch some weird solutions where all words are rejected if the matched words have different case.
marko213
changed the title
kotp
approved these changes
Jul 14, 2019
kotp
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Indentation is nice, thanks @marko213 and @SleeplessByte for catching that.
Looks good.
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Sep 1, 2019
Add two test cases to catch some weird solutions where all words are rejected if the matched words have different case. exercism/cpp#297 exercism/problem-specifications#1552
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Sep 1, 2019
Add two test cases to catch some weird solutions where all words are rejected if the matched words have different case. exercism/cpp#297 exercism/problem-specifications#1552
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Sep 1, 2019
Add two test cases to catch some weird solutions where all words are rejected if the matched words have different case. exercism/cpp#297 exercism/problem-specifications#1552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two test cases to catch some weird solutions where all words are rejected if the matched words have different case.
Original PR on the cpp track: exercism/cpp#297