Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interest-is-interesting: add exercise #1740

Merged
merged 20 commits into from
Oct 11, 2021
Merged

interest-is-interesting: add exercise #1740

merged 20 commits into from
Oct 11, 2021

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Oct 1, 2021 •
edited
Loading

See #1612

@jmrunkle
Copy link
Contributor

jmrunkle commented Oct 1, 2021

@ErikSchierboom - looks like this is failing configlet lint?

The Concept Exercise interest-is-interesting has floating-point-numbers in its concepts, which is not a slug in the top-level concepts array:
/home/runner/work/go/go/config.json

The Concept Exercise interest-is-interesting has for-loops in its prerequisites, which is not in the concepts array of any other user-facing Concept Exercise:
/home/runner/work/go/go/config.json

The Concept Exercise interest-is-interesting has for-loops in its prerequisites, which is not a slug in the top-level concepts array:
/home/runner/work/go/go/config.json

I believe you can "solve" that by simply marking the exercise as "wip" until those are addressed.

@jmrunkle jmrunkle added september-sprint status/awaiting-contributor This pull request is waiting on the contributor. labels Oct 1, 2021
@ErikSchierboom
Copy link
Member Author

@jmrunkle Thanks. I've fixed the first (that was unintentional). The for-loops prerequisite one was intentional. It depends on #1775 being merged.

jmrunkle
jmrunkle reviewed Oct 6, 2021
View reviewed changes
concepts/floating-point-numbers/about.md Outdated Show resolved Hide resolved
concepts/floating-point-numbers/about.md Outdated Show resolved Hide resolved
concepts/floating-point-numbers/about.md Outdated Show resolved Hide resolved
concepts/floating-point-numbers/about.md Outdated Show resolved Hide resolved
concepts/floating-point-numbers/about.md Outdated Show resolved Hide resolved
exercises/concept/interest-is-interesting/.meta/config.json Show resolved Hide resolved
exercises/concept/interest-is-interesting/.meta/design.md Outdated Show resolved Hide resolved
config.json Show resolved Hide resolved
exercises/concept/interest-is-interesting/savings_account_test.go Outdated Show resolved Hide resolved
exercises/concept/interest-is-interesting/savings_account_test.go Outdated Show resolved Hide resolved
@ErikSchierboom @jmrunkle
Apply suggestions from code review
14f2e88 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
ErikSchierboom and others added 12 commits October 7, 2021 07:34
@ErikSchierboom @jmrunkle
Update concepts/floating-point-numbers/about.md
5706ecb 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
@ErikSchierboom @jmrunkle
Update concepts/floating-point-numbers/about.md
1eaed13 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
@ErikSchierboom @jmrunkle
Update concepts/floating-point-numbers/about.md
ee0ce55 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
@ErikSchierboom @jmrunkle
Update concepts/floating-point-numbers/about.md
d398678 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
@ErikSchierboom @jmrunkle
Update exercises/concept/interest-is-interesting/.meta/design.md
8103b4e 
Co-authored-by: Jason Runkle <jmrunkle@gmail.com>
@ErikSchierboom
Remove name parameters
671932c
@ErikSchierboom
Simplify int comparison
e788a7d
@ErikSchierboom
Make floatEqualityThreshold private
b9e5a6b
@ErikSchierboom
Add function for floating-point comparison
e54a57a
@ErikSchierboom
Add type-conversion prerequisite
211cc3c
@ErikSchierboom
Remove unused floating-point concept
4176298
@ErikSchierboom
Simplify return type text
5c82e63
jmrunkle
jmrunkle approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@jmrunkle jmrunkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just need to get configlet lint passing and address a couple small issues.

exercises/concept/interest-is-interesting/.docs/hints.md Outdated Show resolved Hide resolved
exercises/concept/interest-is-interesting/.docs/instructions.md Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member Author

@jmrunkle @junedev I've temporarily removed the prerequisites such that this can now be merged.

@jmrunkle jmrunkle merged commit 620e065 into exercism:main Oct 11, 2021
@jmrunkle jmrunkle added x:size/large Large amount of work and removed status/awaiting-contributor This pull request is waiting on the contributor. labels Oct 11, 2021
@ErikSchierboom ErikSchierboom deleted the integral-numbers branch October 11, 2021 16:12
@junedev junedev mentioned this pull request Oct 13, 2021
Closed
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedev junedev Awaiting requested review from junedev

@ekingery ekingery Awaiting requested review from ekingery

@jmrunkle jmrunkle Awaiting requested review from jmrunkle

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikSchierboom @jmrunkle