bird-watcher: add "for loop" concept #1775

sachinmk27 · 2021-10-03T09:26:12Z

Updated config.json with concept and concept exercise
Added concept exercise directory with minimum valid spec
Added concept directory with about, introduction.

junedev · 2021-10-03T09:34:24Z

I marked this as a draft PR. Click on "ready for review" to when you are ready to change it back to a normal PR.

jmrunkle

Thanks! Many of the documentation comments also need to be applied to the concept and exercise introduction.md files, but I only commented on about.md.

concepts/for-loops/about.md

exercises/concept/bird-watcher/.docs/instructions.md

exercises/concept/bird-watcher/.meta/config.json

ErikSchierboom

Thanks for working on this

concepts/for-loops/about.md

concepts/for-loops/introduction.md

exercises/concept/bird-watcher/bird_watcher.go

exercises/concept/bird-watcher/.docs/introduction.md

jmrunkle · 2021-10-07T15:46:52Z

@sachinmk27 - any chance you will have time to work on this? This is also blocking ErikSchierboom's new exercise interest-is-interesting (unless we remove the prerequisite and add it later).

sachinmk27 · 2021-10-08T16:45:21Z

@jmrunkle Unfortunately I will not be able to make time for the next 4-5 days. Kindly reassign it since it's already delayed.

jmrunkle · 2021-10-08T18:47:48Z

@ErikSchierboom mind waiting? Or perhaps you want to skip adding the prereq until this can be completed?

I'm not particularly motivated to find another contributer if we are ok waiting a bit longer.

ErikSchierboom · 2021-10-11T08:19:38Z

@jmrunkle I don't mind waiting, and I don't mind removing the prerequisite for the moment. @junedev what would your preference be?

junedev · 2021-10-11T13:05:31Z

@ErikSchierboom I would remove the prerequisite and put the other exercise live.

@sachinmk27 Could you clarify whether you would like to finish this later on when you have time or whether we should ask someone else to take over?

sachinmk27 · 2021-10-12T05:50:00Z

@junedev I want to finish it. And I will be able to work on it starting today.

junedev · 2021-10-30T17:36:17Z

@sachinmk27 Could you give me an update again whether you want to finish this PR or whether we should re-assign the task?

sachinmk27 · 2021-10-31T04:42:44Z

Pls reassign the task. Sorry, I couldn't make time for it.

andrerfcsantos · 2021-10-31T10:18:54Z

Pls reassign the task. Sorry, I couldn't make time for it.

No worries, thanks for letting us know :)

github-actions · 2021-10-31T10:31:40Z

Dear sachinmk27

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

📜 The following files usually contain very similar content.
- concepts/<concept>/about.md
- concepts/<concept>/introduction.md
- exercises/concept/<exercise>/.docs/introduction.md
Please check whether the changes you made to one of these also need to be applied to the others.
🧦 If you changed the function signature or the function comment in the exemplar file or the sub file (<exercise>.go), make sure the change is applied to both files.
✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)
🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

_{Automated comment created by PR Commenter 🤖.}

1. Update config.json with concept and concept exercise 2. Add concept exercise directory with minimum valid spec 3. Add concept directory with about, introduction.

Co-authored-by: Jason Runkle <jmrunkle@gmail.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

junedev

Left some ideas for improvement.

concepts/for-loops/about.md

concepts/for-loops/.meta/config.json

concepts/for-loops/about.md

exercises/concept/bird-watcher/.docs/instructions.md

exercises/concept/bird-watcher/bird_watcher.go

exercises/concept/bird-watcher/bird_watcher_test.go

Co-authored-by: June <12543047+junedev@users.noreply.github.com>

junedev · 2021-10-31T20:24:41Z

@andrerfcsantos I only reviewed about.md so fixes you do there need to be applied to the other files as well. ... you probably know the drill. 😉

andrerfcsantos · 2021-10-31T20:48:42Z

@junedev Gotcha. Ready to review again.

code was updated

junedev · 2021-10-31T21:42:38Z

@andrerfcsantos The only thing left is this comment: #1775 (comment)
I approved so you can merge yourself after that last fix.

junedev marked this pull request as draft October 3, 2021 09:32

jmrunkle previously requested changes Oct 3, 2021

View reviewed changes

jmrunkle added september-sprint status/awaiting-contributor This pull request is waiting on the contributor. labels Oct 3, 2021

ErikSchierboom mentioned this pull request Oct 5, 2021

interest-is-interesting: add exercise #1740

Merged

ErikSchierboom reviewed Oct 5, 2021

View reviewed changes

github-actions bot removed the september-sprint label Oct 22, 2021

junedev mentioned this pull request Oct 31, 2021

for-loops: Port "Bird Watcher" exercise from JS or C# #1617

Closed

sachinmk27 and others added 2 commits October 31, 2021 11:44

bird-watcher: Initial commit

925250c

1. Update config.json with concept and concept exercise 2. Add concept exercise directory with minimum valid spec 3. Add concept directory with about, introduction.

Apply suggestions from code review

e8b40a1

Co-authored-by: Jason Runkle <jmrunkle@gmail.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

andrerfcsantos force-pushed the bird-watcher branch from a387c3f to e8b40a1 Compare October 31, 2021 11:45

andrerfcsantos marked this pull request as ready for review October 31, 2021 13:30

andrerfcsantos marked this pull request as draft October 31, 2021 13:35

Add exemplar and tests

8b42d70

andrerfcsantos force-pushed the bird-watcher branch from 1d2671e to 816b4e8 Compare October 31, 2021 16:04

Tweak concept

c905869

andrerfcsantos force-pushed the bird-watcher branch from 816b4e8 to c905869 Compare October 31, 2021 16:06

andrerfcsantos marked this pull request as ready for review October 31, 2021 16:07

Make gocritic happy

df475b8

Mark exercise as beta

e092a89

andrerfcsantos changed the title ~~bird-watcher: Initial commit~~ bird-watcher: add "for loop" concept Oct 31, 2021

andrerfcsantos added hacktoberfest-accepted x:size/large Large amount of work labels Oct 31, 2021

andrerfcsantos requested a review from a team October 31, 2021 19:00

junedev reviewed Oct 31, 2021

View reviewed changes

Apply suggestions from code review

cfe838d

Co-authored-by: June <12543047+junedev@users.noreply.github.com>

andrerfcsantos force-pushed the bird-watcher branch 4 times, most recently from 4dfb4f0 to 830c586 Compare October 31, 2021 20:44

andrerfcsantos force-pushed the bird-watcher branch from 830c586 to 36039cb Compare October 31, 2021 20:54

Manual changes for suggestions on code review

7a796e0

andrerfcsantos force-pushed the bird-watcher branch from 36039cb to 7a796e0 Compare October 31, 2021 20:55

Update test

d123682

andrerfcsantos force-pushed the bird-watcher branch from c5c3ae0 to d123682 Compare October 31, 2021 21:39

junedev approved these changes Oct 31, 2021

View reviewed changes

Update examples

c398f71

andrerfcsantos merged commit 67cb0d2 into exercism:main Oct 31, 2021

This was referenced Jul 14, 2022

Document reputation label exercism/docs#347

Merged

Consider correct reputation amounts for different labels exercism/exercism#6440

Open

Consider correct reputation amounts for different labels exercism/exercism#6441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bird-watcher: add "for loop" concept #1775

bird-watcher: add "for loop" concept #1775

sachinmk27 commented Oct 3, 2021 •

edited by andrerfcsantos

Loading

junedev commented Oct 3, 2021

jmrunkle left a comment

ErikSchierboom left a comment

jmrunkle commented Oct 7, 2021

sachinmk27 commented Oct 8, 2021

jmrunkle commented Oct 8, 2021

ErikSchierboom commented Oct 11, 2021

junedev commented Oct 11, 2021

sachinmk27 commented Oct 12, 2021

junedev commented Oct 30, 2021

sachinmk27 commented Oct 31, 2021

andrerfcsantos commented Oct 31, 2021

github-actions bot commented Oct 31, 2021

junedev left a comment

junedev commented Oct 31, 2021

andrerfcsantos commented Oct 31, 2021

junedev commented Oct 31, 2021

bird-watcher: add "for loop" concept #1775

bird-watcher: add "for loop" concept #1775

Conversation

sachinmk27 commented Oct 3, 2021 • edited by andrerfcsantos Loading

junedev commented Oct 3, 2021

jmrunkle left a comment

Choose a reason for hiding this comment

ErikSchierboom left a comment

Choose a reason for hiding this comment

jmrunkle commented Oct 7, 2021

sachinmk27 commented Oct 8, 2021

jmrunkle commented Oct 8, 2021

ErikSchierboom commented Oct 11, 2021

junedev commented Oct 11, 2021

sachinmk27 commented Oct 12, 2021

junedev commented Oct 30, 2021

sachinmk27 commented Oct 31, 2021

andrerfcsantos commented Oct 31, 2021

github-actions bot commented Oct 31, 2021

Dear sachinmk27

Dear Reviewer/Maintainer

junedev left a comment

Choose a reason for hiding this comment

junedev commented Oct 31, 2021

andrerfcsantos commented Oct 31, 2021

junedev commented Oct 31, 2021

sachinmk27 commented Oct 3, 2021 •

edited by andrerfcsantos

Loading