travis: Support multiple example directories; anagram: Add multiple examples #396
Conversation
| mv ${example}/package.yaml . | ||
| found=1 | ||
|
|
||
| # ARGH, DUPLICATE CODE |
There was a problem hiding this comment.
please help if you can help avoid this duplicate code. use a function?
test_exercise () {
stack test ${SET_RESOLVER} ...
}
and then just call test_exercise ?
There was a problem hiding this comment.
Don't worry with that for now. Let's just add the features and later we can simplify everything. 👍
There was a problem hiding this comment.
The function worked fine so I am going to use it.
| --pedantic `# Enable -Wall and -Werror. ` | ||
| done | ||
|
|
||
| if [ -z "$found" ]; then |
There was a problem hiding this comment.
kind of a clumsy way to do it, but I think it'll work. Any better?
There was a problem hiding this comment.
Not yet...but it is good enough the way it is. 😄
| @@ -0,0 +1,17 @@ | |||
| name: anagram | |||
There was a problem hiding this comment.
this file is pretty much just "the default package.yaml" - perhaps we should support the absence of this file, in which case the one from exercises/anagram/package.yaml is used? the only tricky bit is that it may be overwritten by an earlier example, so we need to back it up beforehand.
There was a problem hiding this comment.
The advantage would be... fewer package.yaml to have to keep up to date if we have to change them all?
the disdavntage would be that the test code would get slightly more complex.
There was a problem hiding this comment.
I would not bother with support for a distinct package.yaml for now. We can solve that later.
| test_exercise | ||
| done | ||
|
|
||
| if [ -z "$found" ]; then |
There was a problem hiding this comment.
I think this does not work as intended. On my computer, at least, if examples dir is empty or does not exist, this is wha thappens:
testing examples/*
mv: cannot stat 'examples/*/*.hs': No such file or directory
mv: cannot stat 'examples/*/package.yaml': No such file or directory
As you can see, since the glob found nothing, it is interpreted literally and we proceed to a single iteration of the for loop. And then mv fails, which I assume will abort the script as it should. But that means this found is unnecessary.
So, is ther ea point in keeping it?
There was a problem hiding this comment.
To me that tells me there is no point in keeping it. I'll remove it.
There was a problem hiding this comment.
Well, I can keep it, I suppose, in case there are shells with different semantics for empty globs.
There was a problem hiding this comment.
Found one link about it, but I couldn't test test it yet.
http://stackoverflow.com/questions/2937407/test-whether-a-glob-has-any-matches-in-bash
There was a problem hiding this comment.
All right, I'll do one with stat
There was a problem hiding this comment.
Do you want to change anything else or can I merge now?
Nice work, BTW. 👍
This serves a few purposes: * Validating that a test suite can accept multiple possible type signatures, such as anagram in #393. * Isolating the `package.yaml` for each example, preventing us from having to show students our example's `package.yaml`. * (With a future extension that marks an example as should-fail) allows us to make sure our test suite catches certain solutions and causes them to fail. Closes #395
This is the first step as a proof of concept that the examples directory will work and will be tested by Travis CI. The next step would be to add other examples alongside this one. As part of the work in #395.
Closes #395 (though I will plan to open a new issue to be able to mark an example as should-fail. Perhaps with a SHOULDFAIL in its directory name?)
Individual commits should explain well enough.