-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: Cache examples separately #406
Conversation
Ah. To be clear, I have nothing against the second solution, it was just that the first was the path of least resistance currently |
@@ -68,6 +68,10 @@ script: | |||
exit 1 | |||
else | |||
for example in examples/*/ ; do | |||
examplename=$(basename example) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, needs to be $example
.
PR #396 gives us the power to have multiple examples. But if the examples have different dependencies, their caches clobber each other. Thus, it seems necessary to have a separate cache per example. There is some discussion on this and some proposed solutions in #397. We may replace this shell script soon, but it will at least let us know the strategy we want to use and validate the directory layout.
Okay, travis seems to have fine paths here. /home/travis/.foldercache/home/travis/build/exercism/xhaskell/exercises/anagram/list-string/.stack-work/dist/x86_64-linux/Cabal-1.24.0.0/build/Anagram.dyn_hi /home/travis/.foldercache/home/travis/build/exercism/xhaskell/exercises/anagram/list-string/.stack-work/dist/x86_64-linux/Cabal-1.24.0.0/build/Anagram.dyn_o Unrelated, but if we would use |
Edit: Sorry...it's there. |
Hold on, I thought the Or are you talking about something different? If the package.yaml didn't get moved in the above fashion, I would be surprised that some of the examples even build... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad...everything seems perfect.
OK, I'm going to create another issue for the basename thing since I might not get to it just yet. |
PR #396 gives us the power to have multiple examples. But if the
examples have different dependencies, their caches clobber each other.
Thus, it seems necessary to have a separate cache per example.
There is some discussion on this and some proposed solutions in #397.
We may replace this shell script soon, but it will at least let us know
the strategy we want to use and validate the directory layout.