-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Concept Exercise Poetry Door Club Policy (strings) #1342
Improve Concept Exercise Poetry Door Club Policy (strings) #1342
Conversation
Suggestion on this. Rename the |
@iHiD Already on my cleanup list. 🙂 |
Hi, im still having same issue as 1338 in this comment >
However after the exercise was updated today it's just receiving an empty array instead and still failing. Any help? Thanks a bunch! |
@DietCoke955 Please note that this is a draft PR (a work in progress). Its not yet available on the website therefore the issues in #1338 might still exist. The only change that went live recently was a cleanup of the test code. But that by itself probably did not "fix" anything yet. It would be great if you could post a code example how to reproduce your issue and see that empty array into #1338. |
expect(recite(SHIRE_HORSE, frontDoorResponse)).toStrictEqual( | ||
expectedLetters | ||
); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this test case as it didn't test anything that isn't also tested by the next and because it uses the same example that is already shown in the instructions, same below for the back door part
👍 LGTM |
Resolves #1338
Changes