Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format track config with configlet fmt #2321

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

BNAndras
Copy link
Member

The configlet CI is currently failing because configlet fmt is showing the track config to be unformatted. This is a recently added check for configlet.

@BNAndras BNAndras changed the title Format track config with configlet fit Format track config with configlet fmt Nov 17, 2023
@BNAndras
Copy link
Member Author

Right, if I run ./bin/format.sh, we go back to the original formatting that configlet fmt doesn't like. configlet fmt should format the config.json files so maybe prettier shouldn't format those JSON files. That'll let us make both CI checks happy.

Copy link
Contributor

The "Format code" action has started running.

Copy link
Contributor

The "Format code" action has finished running.

Copy link
Contributor

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Member

If we want to format it using configlet, we should probably:

  • ignore the file using .prettierignore
  • update format.sh to call both prettier and configlet.

I would be happy to see that change!

@BNAndras
Copy link
Member Author

I’ll take a look. configlet create now formats the track config as well so that this issue is likely to come up again.

@SleeplessByte
Copy link
Member

Understood! Ping me when done or if you cannot figure it out and I'll fix it ;)

@BNAndras
Copy link
Member Author

BNAndras commented Feb 2, 2024

Last commit was because raindrops has an exercism/note section in the instructions.md. Prettier wanted to revert the tildes to backticks.

@BNAndras
Copy link
Member Author

BNAndras commented Feb 2, 2024

@SleeplessByte, the CI is passing.

@SleeplessByte SleeplessByte merged commit 511bd77 into exercism:main Feb 2, 2024
7 checks passed
@BNAndras BNAndras deleted the format-track-config branch February 2, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants