Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Alerts Markdown support #2368

Merged
merged 10 commits into from
Feb 2, 2024
Merged

Adds Alerts Markdown support #2368

merged 10 commits into from
Feb 2, 2024

Conversation

cr2007
Copy link
Contributor

@cr2007 cr2007 commented Jan 22, 2024

With Alerts being supported on GitHub recently, this PR adds the updated markdown support to indicate the importance of the text.

Example:

Important

We 💙 our community but this repository does not accept community contributions at this time.

There are no active maintainers to review PRs.

Please read this [community blog post][freeing-maintainers] for details.

Reference: https://github.com/orgs/community/discussions/16925

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 22, 2024
@cr2007
Copy link
Contributor Author

cr2007 commented Jan 26, 2024

I've added it in the forum.

Here is the link for the same: http://forum.exercism.org/t/adds-alerts-markdown-support/9343

@SleeplessByte SleeplessByte reopened this Feb 1, 2024
@SleeplessByte
Copy link
Member

/format

Copy link
Contributor

github-actions bot commented Feb 1, 2024

The "Format code" action has started running.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

The "Format code" action has finished running.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

For security reasons, /format does not trigger CI builds when the PR has been submitted from a fork. If checks were not passing due to code format, trigger a build to make the required checks pass, through one of the following ways:

  • Push an empty commit to this branch: git commit --allow-empty -m "Trigger builds".
  • Close and reopen the PR.
  • Push a regular commit to this branch.

@SleeplessByte
Copy link
Member

This is blocked by #2321

@SleeplessByte
Copy link
Member

Could you rebase this on main?

@cr2007
Copy link
Contributor Author

cr2007 commented Feb 2, 2024

Could you rebase this on main?

Like, I merge this branch to the main branch in my fork?

@SleeplessByte
Copy link
Member

Could you rebase this on main?

Like, I merge this branch to the main branch in my fork?

I meant using git rebase to effectively unwind all the changes, get the latest changes from main and then re-apply this branch on top. This way, any changes we have since made to main will show up here (including the formatting fixes), without a merge commit.

Anyway, I've gone ahead and applied the changes and fixed the formatting of config.json (not broken in this PR, but made it all fail).

@SleeplessByte SleeplessByte merged commit 97817c4 into exercism:main Feb 2, 2024
6 checks passed
@cr2007 cr2007 deleted the markdown-update branch February 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants