-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI broken because of Ubuntu PPA missing package #308
Comments
Hi @marionebl. Excellent work in #306, and sorry, I didn't see your side note before creating this issue. I'd prefer to stick to Travis CI, because this appears to be what the Exercism project uses, but it looks like we're currently using an Ubuntu PPA to download an old (and now missing) Ocaml + OPAM package, and we could be using the exact same ocaml/opam2 Docker image as you demonstrate with Circle CI. Is that correct? In that case, you are very welcome to submit another PR for this particular problem. I think we'll be happier to review other PRs including #306 when CI is working. :-) |
I tried toying around with Travis CI and some modified Travis configuration on https://github.com/sshine/exercism-ocaml/tree/fix-travis-ci inspired by your Circle CI configuration, @marionebl. Because my knowledge of Docker is limited, my most successful attempt was to install https://travis-ci.com/sshine/exercism-ocaml/jobs/209178155#L259
The |
Ok, I created a PR reflecting this at #310. The downside of using Travis CI is the jobs do not cache the things executed in the docker environment, resulting in quite a time delta:
Looking esp. at the opam install times this might become relevant down the line. We still could address this and continue with Travis CI by creating a docker image that builds on |
Use the `ocaml/opam2` Docker image for CI. Explicitly use OCaml 4.07.0 for now. Pin base to v0.11.1 to avoid breaking changes as documented in exercism#301. This fixes exercism#308.
The PR #306 currently demonstrates that the Ubuntu PPA we use for downloading ocaml42+opam12 is broken, since this package appears to be gone. This PPA was used added around the time of 4.02, but today even the regular Ubuntu
ocaml-nox
package is 4.05. The solution would be to change.travis-ci.sh
so that it uses a source that does not break.This could either be with
apt install ocaml-nox opam
, oropam switch create 4.08.0
, but this builds the compiler which takes several minutes on my i5-7200U CPU @ 2.50GHz.@stevejb71: If we fix this CI problem, it also addresses #287. I tried to upgrade to Opam 2.0.x and played with
opam switch create 4.08.0
to see how long it takes, and it appears to be stuck atmake world
for a while. So I think we should be going for a binary distribution.An alternative is Docker images, but the one for 4.08 isn't out yet. We could of course start with 4.07 and simply bump it up when the time comes. I don't really know much about Docker, and I don't know of the implications of changing .travis.yml in this way. Resources:
From the Travis CI logs at https://travis-ci.org/exercism/ocaml/builds/545910314 it says:
The text was updated successfully, but these errors were encountered: