-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add implementation stubs (fixes #285, fixes #298) #306
Conversation
CI failure appears to be unrelated. |
@@ -0,0 +1,15 @@ | |||
open Base | |||
|
|||
module Int_map = Map.M(Int) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses #298
As a side note: I dug into the CI setup a bit and created this version using CircleCI: Maybe this also of interest for another PR? |
Closing and opening PR to trigger CI. (I wonder if this is the best way.) |
@marionebl: Could you merge master onto this feature branch? I'm a little confused about the merge conflict; not sure if it's caused by leaving stuff out by intent, or because of breaking changes with base 0.12, or what. Edit: Also, is this PR intended to be merged? I don't mind that stubs are added for a bunch of exercises at once, since the histories for those files start at nothing. |
I'll get this into a mergable state as soon as the spin offs for #311 land |
One thing I don't like about this is the fact we do not have an automated test for the stub files as I did not find a way to build the tests without executing them. Edit: One way to address this might be adding a new alias to the dune files (alias
(name buildtest)
(deps (:x test.exe))) Executing |
@marionebl: My model track is Haskell's, and here we run all tests of all example solutions on every CI run. Come to think of it, this is somewhat wasteful. I don't really know of the particular implications of adding such a build target alias -- my practical experience with OCaml build tools are very limited -- but I like the purpose very much. If you're interested in becoming a co-maintainer for the OCaml track, you are very welcome. If you prefer to submit changes as you have been doing so far, you are also very welcome. |
I'd be glad to!
I'd continue submitting PRs even as maintainer so everyone stays on the same page. |
@marionebl: Yes, that'd be ideal as long as we're more than one active maintainer, since we get the luxury of fault detection. (I don't think I can supplement your knowledge of CI and OCaml build tools, but four eyes are better than two!)
|
@kytrinyx will sort these for you. |
@marionebl Welcome. Ping me on Slack and I'll add you to the #maintainers channel :) |
@marionebl Welcome! Thank you so much for contributing ✨ I've sent the invitation to join the exercism/ocaml team, and have turned on branch protection for the master branch. Let me know if anything is wonky, I always worry that I get things wrong when messing with repo settings. |
As per