[Haskell] v3 config.json stub #51
Conversation
This stub contains all things necessary but the list of exercises. The example C# config.json did not contain the fields `ignore_pattern` and `solution_pattern` present in Haskell's config.json, but the [migration guide][1] also did not speak of deprecating any properties. For this reason, this PR preserves those properties and adds new ones. [1]: https://github.com/exercism/v3/blob/master/docs/maintainers/migrating-your-config-json-files.md
|
Note: I was unable to tag this pull request with a meaningful |
The config.json is updated with v3 properties in 24cea63.
Co-Authored-By: Tim Austin <tim@neenjaw.com>
declarationperfume
changed the title
Could |
Wouldn't that indicate that I'm not completely done pushing changes? I'm really looking for a |
|
Or maybe |
Hmmm, I'm thinking for PR's these statuses might not make as much sense. Either it is ready for review, or it is not, in which case it should be a draft PR. Would that work? |
| "exercises": { | ||
| "concept": [], | ||
| "practice": [] | ||
| } |
There was a problem hiding this comment.
It looks like the "foregone" exercises have also been removed. See https://github.com/exercism/haskell/blob/dc01f701596c6726b4c6f31acf9e97df840139ef/config.json#L7. Was that intentional?
There was a problem hiding this comment.
Sort of. I deliberately didn't add the exercise-specific data because migrating-your-config-json-files.md says:
The existing exercises are temporarily removed from the
config.jsonfile. They will return as practice exercises once the concept exercises have been added.
I thought it was slightly strange to mention which practice exercises have been foregone when not mentioning which practice exercises that are implemented. So I thought I would add foregone exercises after I've added practice exercises after I've added 20+ concept exercises. At least that's how I understood the recommended workflow.
There was a problem hiding this comment.
You are entirely correct of course. I'll update the migrate guide to also mention removing the foregone key.
I contemplated extending |
This stub contains all things necessary but the list of exercises.
The example C# config.json did not contain the fields
ignore_patternandsolution_patternpresent in Haskell's config.json, but the migration guide also did not speak of deprecating any properties.For this reason, this PR preserves those properties and adds new ones.