Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Haskell] v3 config.json stub #51

Merged
merged 3 commits into from
Jan 17, 2020
Merged

[Haskell] v3 config.json stub #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24cea63
Haskell: v3 config.json stub
sshine Jan 15, 2020
d7f7171
Haskell: Update README.md with progress
sshine Jan 15, 2020
157b1b5
Haskell: Fix copy-paste error in config.json
sshine Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions languages/haskell/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ Before launch, we need all of the following parts to be completed:

- [ ] Implemented 20+ Concept Exercises
- [ ] [Updated `config.json`](../../docs/maintainers/migrating-your-config-json-files.md)
- [ ] Added `version` key
- [ ] Added online editor settings
- [ ] Added `indent_style`
- [ ] Added `indent_size`
- [x] Added `version` key
- [x] Added online editor settings
- [x] Added `indent_style`
- [x] Added `indent_size`
- [ ] Added Concept Exercises
- [ ] Added Concepts for all Practice Exercises

Expand Down
16 changes: 16 additions & 0 deletions languages/haskell/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"language": "Haskell",
"version": 3,
"active": true,
"blurb": "Haskell is a functional programming language which is pure and statically-typed. It's known for lazy evaluation, where evaluation is deferred until necessary, and its purity, where monads are used for working with side-effects.",
"online_editor": {
"indent_style": "space",
"indent_size": 2
},
"ignore_pattern": "example",
"solution_pattern": "example.*[.]hs",
"exercises": {
"concept": [],
"practice": []
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the "foregone" exercises have also been removed. See https://github.com/exercism/haskell/blob/dc01f701596c6726b4c6f31acf9e97df840139ef/config.json#L7. Was that intentional?

Copy link
Contributor Author

@sshine sshine Jan 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. I deliberately didn't add the exercise-specific data because migrating-your-config-json-files.md says:

The existing exercises are temporarily removed from the config.json file. They will return as practice exercises once the concept exercises have been added.

I thought it was slightly strange to mention which practice exercises have been foregone when not mentioning which practice exercises that are implemented. So I thought I would add foregone exercises after I've added practice exercises after I've added 20+ concept exercises. At least that's how I understood the recommended workflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are entirely correct of course. I'll update the migrate guide to also mention removing the foregone key.

}