Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'gpu' marker to test suite #208

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add 'gpu' marker to test suite #208

merged 1 commit into from
Jul 10, 2023

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jul 7, 2023

Description

Add 'gpu' marker to voluntarily disable GPU tests if they aren't needed.
Note: This will be followed up by a PR to adjust our GPU BuildKite test script to use --gpu.

Types of change

Enhancement to test suite.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added enhancement Improvement of existing feature tests Everything related to the test suite labels Jul 7, 2023
@rmitsch rmitsch self-assigned this Jul 7, 2023
@rmitsch rmitsch changed the title Add 'gpu' marker Add 'gpu' marker to test suite Jul 7, 2023
@rmitsch rmitsch marked this pull request as ready for review July 7, 2023 14:52
@svlandeg svlandeg merged commit ff74143 into main Jul 10, 2023
@svlandeg svlandeg deleted the tests/gpu-marker branch July 10, 2023 16:31
rmitsch added a commit that referenced this pull request Jul 12, 2023
@rmitsch @svlandeg
Merge pull request #213 from explosion/main
9eef85d 
* Fix regex -> re import. (#205)

* Add 'gpu' marker. (#208)

* Optional authentation verification at init time (#206)

* Add verify_auth param.

* Add _verify_auth() for Cohere and Anthropic.

* Make auth check mandatory again.

* Remove redundant PR.

* Fix OpenLLaMA model names (#209)

* Update PR template. (#207)

* Update OpenLLaMA model names.

* fix model name in documentation (#210)

* Bump version to 0.4.1. (#211)

---------

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees

@rmitsch rmitsch

Labels
enhancement Improvement of existing feature tests Everything related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmitsch @svlandeg