Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix model name in documentation #210

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix model name in documentation #210

merged 1 commit into from
Jul 11, 2023

Conversation

svlandeg
Copy link
Member

Description

We've got our model names wrong in the documentation, it should be "gpt-3.5-turbo" instead of "gpt-3-5-turbo". We only replace with hyphens in the registered name for @llm_models 😭

In follow-up work, we should consider matching the names of the model in a case-invariant, punctuation-ignoring fashion. But that'd require a bugfix release, so I suggest we update the documentation now first, because the current example code results in

Config validation error
llm.model -> name	unexpected value; permitted: 'gpt-3.5-turbo', 'gpt-3.5-turbo-16k', 'gpt-3.5-turbo-0613', 'gpt-3.5-turbo-0613-16k'
{'@llm_models': 'spacy.GPT-3-5.v1', 'name': 'gpt-3-5-turbo', 'config': {'temperature': 0.30000000000000004}, 'strict': True}

Types of change

docs bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the documentation Improvements or additions to documentation label Jul 11, 2023
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, sloppy replace on my part.

@rmitsch rmitsch merged commit 1072a57 into main Jul 11, 2023
@svlandeg svlandeg deleted the fix/name branch July 11, 2023 10:17
rmitsch added a commit that referenced this pull request Jul 12, 2023
* Fix regex -> re import. (#205)

* Add 'gpu' marker. (#208)

* Optional authentation verification at init time (#206)

* Add verify_auth param.

* Add _verify_auth() for Cohere and Anthropic.

* Make auth check mandatory again.

* Remove redundant PR.

* Fix OpenLLaMA model names (#209)

* Update PR template. (#207)

* Update OpenLLaMA model names.

* fix model name in documentation (#210)

* Bump version to 0.4.1. (#211)

---------

Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants