Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Improve feedback to the user when an error occurs #64

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Sep 18, 2023

Why

We should give some sort of feedback to the user when errors occur instead of silently falling

How

  • Improve feedback to the user when an error occurs
  • Move common-types to a package
  • Update the list-devices output format to include more details on errors
  • Add warning to device list when an error occurs

Test Plan

Screen.Recording.2023-09-20.at.23.18.15.mov

@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/improve-error-messages branch from df8eabe to f8c83ff Compare September 20, 2023 15:39
@gabrieldonadel gabrieldonadel marked this pull request as ready for review September 21, 2023 02:47
@gabrieldonadel gabrieldonadel merged commit dc6a029 into main Sep 21, 2023
2 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/improve-error-messages branch September 21, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant