Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: 'Language-ize' remaining static content #353

Closed
exponentcms opened this issue Apr 27, 2020 · 66 comments
Closed

Upgrade: 'Language-ize' remaining static content #353

exponentcms opened this issue Apr 27, 2020 · 66 comments
Assignees
Labels

Comments

@exponentcms
Copy link
Owner

Now that the 2.0 expLang subsystem is fully implemented and the 1.0 lang subsystem is deprecated. it might be a good idea to converts some of the static text in the templates to use the gettext (or gt) functions. E.g., The 'Save' button should become whatever 'Save' is in the selected language instead of a mix of English and selected language

@exponentcms
Copy link
Owner Author

Next we'll want to 'language-ize' all the installation, site configuratoin, & migration screens.

We MUST be cautious of placing quotes inside the gettext/gt calls as it will break the site.

@exponentcms
Copy link
Owner Author

(from [874d516]) Updates some language which breaks language system (uses double quotes, etc...) Most of the existing views reached from the slingbar are now scrubbed but need more 'language-izing [#369 ][#296]
874d516

@exponentcms
Copy link
Owner Author

(from [46ee9df]) Strips out double-quotes before getting into the translation routines to prevent breaking the site with a bad language file [#296]
46ee9df

@exponentcms
Copy link
Owner Author

(from [6a80ed7]) expLang replaces double-quotes with single-quote before getting into the translation routines to prevent breaking the site with a bad language file, administration module now language-ized with updated English template [#296]
6a80ed7

@exponentcms
Copy link
Owner Author

(from [1d8b1f5]) Language-izes text module, also makes use of updated icon plugin [#296]
1d8b1f5

@exponentcms
Copy link
Owner Author

(from [b64dbc3]) Language-izes recycle bin module [#296]
b64dbc3

@exponentcms
Copy link
Owner Author

(from [abfd2d8]) Language-izes snippet module, also makes use of updated icon plugin [#296]
abfd2d8

@exponentcms
Copy link
Owner Author

(from [1f4691b]) Removes some symbols being brought over into the language template [#296]
1f4691b

@exponentcms
Copy link
Owner Author

(from [b33cd47]) Language-izes user & login modules [#296]
b33cd47

@exponentcms
Copy link
Owner Author

(from [39abaaf]) Language-izes twitter module templates [#296]
39abaaf

@exponentcms
Copy link
Owner Author

(from [32e63bc]) Language-izes youtube module templates [#296]
32e63bc

@exponentcms
Copy link
Owner Author

(from [a879928]) Language-izes core & search controller templates [#296]
a879928

@exponentcms
Copy link
Owner Author

(from [8d75776]) More Language-ized updates [#296]
8d75776

@exponentcms
Copy link
Owner Author

(from [efb2aea]) More Language-ized updates to common & core views, fwiw, we can't use generic icon plugin for things like expTags, because that's the model name when we'd need to to say 'tag' instead of 'expTag' [#296]
efb2aea

@exponentcms
Copy link
Owner Author

(from [87fced9]) Makes writeTemplate a static method since it's called that way, updates the English phrase library [#296]
87fced9

@exponentcms
Copy link
Owner Author

(from [5de833c]) Adds flowplayer 'skin' selection & languagizes flowplayer [#378 milestone:2.0.3 owner:dleffler] [#296]
5de833c

@exponentcms
Copy link
Owner Author

(from [1b876fa]) Adds option to display media player (flowplayer) in filedownloads if file is mp3, flv or f4v, also languagizes filedownloads [#379 state:resolved milestone:2.0.3 owner:dleffler] [#296]
1b876fa

@exponentcms
Copy link
Owner Author

(from [1830f04]) More Language-ized updates to file, portfolio, & rss modules, and other minor edits [#296]
1830f04

@exponentcms
Copy link
Owner Author

(from [b8b82cd]) More Language-ized updates to not found, photoalbum, & pixidou modules, and other minor edits [#296]
b8b82cd

@exponentcms
Copy link
Owner Author

(from [45e1c3c]) More Language-ized updates to news module [#296]
45e1c3c

@exponentcms
Copy link
Owner Author

(from [bf0e1a8]) More Language-ized updates to migration & motd modules [#296]
bf0e1a8

@exponentcms
Copy link
Owner Author

(from [7268a7a]) More Language-ized updates to help & links modules [#296]
7268a7a

@exponentcms
Copy link
Owner Author

(from [05b06fe]) More Language-ized updates to headline, flickrfeed, faq, & importexport modules, and all 'buttongroups' [#296]
05b06fe

@exponentcms
Copy link
Owner Author

(from [916023e]) More Language-ized remaining modules for the most part [#296]
916023e

@exponentcms
Copy link
Owner Author

(from [a8cc018]) More Language-ized remaining old school modules, required revising some calendar display code to language-ize the recurring part of the form.

At this point the following still remains:

  • E-commerce hasn't been touched except for the buttons
  • There are some of the delete confirm statements that aren't language-ized
  • The .tpl file probably need to be reviewed to make sure i caught everything
  • The text injected by the controller (not in a .tpl) is still mostly hard-coded, but should be updated
  • There are still a lot of phrases that haven't been 'tripped' across to have them added to the default phrase library (English - US.php)
  • There should probably be a general consolidation of some of the phrases so the translation file is smaller, yet would have a greater impact across the system. e.g., break apart a long phrase into the portion that is used most often, and 'cat' it to the remainder of the phrase.
  • There are probably still some 'bad' phrases in the templates, though they won't break the system (anymore), they won't translate. These would be ones with symbols like quotes, etc...
    [Update Smarty library to 2.6.26 #296]
    a8cc018

@exponentcms
Copy link
Owner Author

(from [09ab1fd]) Adds some additional info to manage languages view, including an automated translation command (requires a Bing API value constant being set), also includes a new spanish translation ran through the automated translator [#296]
09ab1fd

@exponentcms
Copy link
Owner Author

(from [7db7ab7]) Fixes some quirks with language in install & login [#296]
7db7ab7

@exponentcms
Copy link
Owner Author

(from [30b3809]) Few more tweaks to installer language support and language phrases [#296] [#395 state:resolved owner:dleffler milestone:2.0.3]
30b3809

@exponentcms
Copy link
Owner Author

(from [95bc6b0]) Updated Language files for all the 'expValidator::failAndReturnToForm' calls [#296]
95bc6b0

@exponentcms
Copy link
Owner Author

(from [adb606d]) Language-izes all the 'expValidator::failAndReturnToForm' calls [#296]
adb606d

@exponentcms
Copy link
Owner Author

(from [3be1fe6]) Language-izes the home page name on an install and the hard-links in coolwater theme. [#296]
3be1fe6

@exponentcms
Copy link
Owner Author

(from [724764d]) Cleans up language file by removing obsolete phrases (script updated) and changes espanol filename to one without special characters which was causing issues between OS's [#296]
724764d

@exponentcms
Copy link
Owner Author

(from [65e9782]) Removes old espanol files [#296]
65e9782

@exponentcms
Copy link
Owner Author

(from [d6a4f12]) Adding the new espanol files [#296]
d6a4f12

@exponentcms
Copy link
Owner Author

(from [4bd5b47]) Updated (and cleaned) language files (English, Spanish, & German) [#296]
4bd5b47

@exponentcms
Copy link
Owner Author

(from [fa70319]) Better Language-izes {icon} [#296]
fa70319

@exponentcms
Copy link
Owner Author

(from [ef02f7e]) Language-izes all of the delete confirmation messages [#296]
ef02f7e

@exponentcms
Copy link
Owner Author

(from [713e59b]) Language files (English, Spanish, & German) updated for all of the delete confirmation messages [#296]
713e59b

@exponentcms
Copy link
Owner Author

(from [521d48e]) Correct Spanish Language file (special characters were mucked in the filename change) and language-izes the permission names. [#296]
521d48e

@exponentcms
Copy link
Owner Author

(from [56d6794]) Adds Language selection to the Manage Translations view [#296]
56d6794

@exponentcms
Copy link
Owner Author

(from [1d98ed0]) Update Language locales [#296]
1d98ed0

@exponentcms
Copy link
Owner Author

(from [6223f83]) Adds Norwegian (machine) translation [#296]
6223f83

@exponentcms
Copy link
Owner Author

(from [87bf699]) Cleans up some mis-quoted language phrases [#296]
87bf699

@exponentcms
Copy link
Owner Author

(from [3f81756]) Adds Danish (machine) translation, plus some other language corrections [#296]
3f81756

@exponentcms
Copy link
Owner Author

(from [b211efd]) Adds Czech (machine) translation, plus some other language corrections [#296]
b211efd

@exponentcms
Copy link
Owner Author

(from [853926f]) Adds some additional language-izing, including some javascript in the php code like the file manager & menu/page hierarchy [#296] [#394]
853926f

@exponentcms
Copy link
Owner Author

(from [41f7cc2]) Minor updates to Language-izing [#296]
41f7cc2

@exponentcms
Copy link
Owner Author

(from [7a5af60]) Language-izes some text in plugins and controls, also some comment typos fixed [#296]
7a5af60

@exponentcms
Copy link
Owner Author

(from [f6b6b72]) Adds Finnish translation and updates other translations [#296]
f6b6b72

@exponentcms
Copy link
Owner Author

(from [8f59f7b]) Language-izes related products template (was looking for another bug and tripped across these) [#296]
8f59f7b

@exponentcms
Copy link
Owner Author

(from [e7c814c]) Language-izes word in file control (Limit) [#296]
e7c814c

@exponentcms
Copy link
Owner Author

(from [7a084d8]) Some language updates [#296]
7a084d8

@exponentcms
Copy link
Owner Author

(from [d6272cf]) Updates control, ddrerank, & icon smarty plugins to assist with translation if not sent to them in the non-english form...HOWEVER, if the construct doesn't run through the |gettext modifier, it probably hasn't been extracted and placed in the phrase library. [#296]
d6272cf

@exponentcms
Copy link
Owner Author

[bulk edit]

@exponentcms
Copy link
Owner Author

This will always be on-going, we'll call it closed w/ v2.0.3 released.

@exponentcms
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants