Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: option to allow any file #229

Merged
merged 1 commit into from
Oct 23, 2015
Merged

lib: option to allow any file #229

merged 1 commit into from
Oct 23, 2015

Conversation

LinusU
Copy link
Member

@LinusU LinusU commented Sep 19, 2015

Allows the receiving of files regardless of their fieldname.

I'm still not sure if we should merge this. @jpfluger, @hacksparrow, what are your thoughts?

@imZack
Copy link

imZack commented Sep 23, 2015

Needs this feature 👍

@mjhasbach
Copy link

+1

@no-donut-for-you
Copy link

+1

@ficristo ficristo mentioned this pull request Oct 2, 2015
@JedWatson
Copy link

I think this is a valuable addition; there are cases in dynamic systems (e.g. CMS) where the field configuration can't be known before a form is submitted, especially when developing a generic API endpoint that may handle updating different types of objects, as per the GraphQL use case.

It seems like the explicit field naming was introduced as a best practice / security feature (?) but for some cases an explicit opt-in to dynamically detect & accept any file fields would be useful.

@JedWatson
Copy link

@LinusU @jpfluger @hacksparrow any chance we can get an indication of whether this will be merged / implemented? otherwise I'll start working on an alternate solution.

@LinusU
Copy link
Member Author

LinusU commented Oct 21, 2015

I could probably merge it for you tonight (Swedish time) 🍰

@jpfluger
Copy link
Contributor

@LinusU, I'm good with this addition. I also appreciate the warning in the readme.

@hacksparrow
Copy link
Member

👍

@JedWatson
Copy link

Thanks 💯

LinusU added a commit that referenced this pull request Oct 23, 2015
lib: option to allow any file
@LinusU LinusU merged commit 20d8493 into master Oct 23, 2015
@LinusU LinusU deleted the any-file branch October 23, 2015 05:52
@LinusU
Copy link
Member Author

LinusU commented Oct 23, 2015

Released as 1.1.0 :shipit: 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants