Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Multer #1563

Closed
JedWatson opened this issue Jul 31, 2015 · 7 comments
Closed

Update Multer #1563

JedWatson opened this issue Jul 31, 2015 · 7 comments

Comments

@JedWatson
Copy link
Member

Multer has been updated with breaking changes to the API. We need to review the changes and update the implementation in lib/core/mount.js accordingly.

@JedWatson JedWatson added this to the 0.3.x milestone Jul 31, 2015
@JedWatson JedWatson modified the milestones: 0.4.0, 0.3.x Oct 5, 2015
@JedWatson
Copy link
Member Author

So this is going to be much simpler is expressjs/multer#229 is merged, otherwise we'll have to change the public API significantly for application routes and pre-generate Admin UI routes that accept white-listed field names. Fingers crossed.

@mxstbr
Copy link
Collaborator

mxstbr commented Apr 29, 2016

This can be closed

@mxstbr mxstbr closed this as completed Apr 29, 2016
@JedWatson
Copy link
Member Author

@mxstbr actually... multer is still pinned to an old version, this is still an active concern. Just lower priority than other issues in 0.4

@JedWatson JedWatson reopened this Apr 29, 2016
@bassjacob
Copy link
Contributor

I've picked this up at keystonejs/keystone#3794 and will make the changes there.

@jstockwin
Copy link
Contributor

So this is going to be much simpler is expressjs/multer#229 is merged

This has been merged and released into 1.1.0, if this helps anything? cc/@bassjacob @JedWatson

@bassjacob
Copy link
Contributor

yep, the .any change should make this an out of the box fix. I'm going to have a look into their security recommendations and timebox that before just shipping to .any change.

@stennie
Copy link
Contributor

stennie commented Jul 7, 2018

Closing as a duplicate of #4428, which will be addressed in Keystone 4.0.0-rc.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants