-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate dependency maintenance. #1903
Conversation
After this PR, we'll want to turn on Greenkeeper.io. └[∵┌]└[ ∵ ]┘[┐∵]┘
👍 |
This PR has 4 major version bumps that need to be investigated more carefully by somebody more familiar with the code. (☞゚∀゚)☞ @JedWatson |
Two things to call out:
they've migrated the package to es6 without shipping a transpiled build, which means we would need to change our build process to babelify it ourselves and use in node.js would break compatibility with 0.10/12 which Keystone still currently targets. So for that, and to prevent duplicates in the client-side bundle (w/ history), we're leaving it where it is until there's a better option. I'd like to move away from it entirely. I haven't tested babel-eslint@5.0.0-beta4 but I expect we can work through any issues that come up (if any) Everything else looks 👍 |
We should file this as a bug against their repo. |
I found a bug in this today. I'm going to re-pin an older version. |
Good to go! Thanks @ericelliott |
Automate dependency maintenance.
From issues I've already read, they're aware and don't care. The whole project has had a call for maintainers. It also looks like client side support is being dropped, based on a thread on the history repo (where we're discussing moving to a different package) |
Is there an issue tracking the replacement? |
👍 |
After this PR, we'll want to turn on Greenkeeper.io.
└[∵┌]└[ ∵ ]┘[┐∵]┘