Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate dependency maintenance. #1903

Merged
merged 2 commits into from
Dec 3, 2015
Merged

Automate dependency maintenance. #1903

merged 2 commits into from
Dec 3, 2015

Conversation

ericelliott
Copy link
Contributor

After this PR, we'll want to turn on Greenkeeper.io.

└[∵┌]└[ ∵ ]┘[┐∵]┘

After this PR, we'll want to turn on Greenkeeper.io.

└[∵┌]└[ ∵ ]┘[┐∵]┘
@svenheden
Copy link

👍

@ericelliott
Copy link
Contributor Author

This PR has 4 major version bumps that need to be investigated more carefully by somebody more familiar with the code.

(☞゚∀゚)☞ @JedWatson

@JedWatson
Copy link
Member

Two things to call out:

  • multer currently needs to be pinned at 0.1.8 (see Update Multer #1563)
  • qs needs to be pinned at 4.0.0, this is aligned with the dependency in history.

qs is basically (╯°□°)╯︵ ┻━┻

they've migrated the package to es6 without shipping a transpiled build, which means we would need to change our build process to babelify it ourselves and use in node.js would break compatibility with 0.10/12 which Keystone still currently targets.

So for that, and to prevent duplicates in the client-side bundle (w/ history), we're leaving it where it is until there's a better option. I'd like to move away from it entirely.

I haven't tested babel-eslint@5.0.0-beta4 but I expect we can work through any issues that come up (if any)

Everything else looks 👍

@JedWatson JedWatson changed the title Autamte dependency maintenance. Automate dependency maintenance. Dec 3, 2015
@ericelliott
Copy link
Contributor Author

they've migrated the package to es6 without shipping a transpiled build, which means we would need to change our build process to babelify it ourselves and use in node.js would break compatibility with 0.10/12 which Keystone still currently targets.

We should file this as a bug against their repo.

@ericelliott
Copy link
Contributor Author

I haven't tested babel-eslint@5.0.0-beta4

I found a bug in this today. I'm going to re-pin an older version.

@JedWatson
Copy link
Member

Good to go! Thanks @ericelliott

JedWatson added a commit that referenced this pull request Dec 3, 2015
Automate dependency maintenance.
@JedWatson JedWatson merged commit 1e5d5af into master Dec 3, 2015
@JedWatson
Copy link
Member

We should file this as a bug against their repo.

From issues I've already read, they're aware and don't care. The whole project has had a call for maintainers. It also looks like client side support is being dropped, based on a thread on the history repo (where we're discussing moving to a different package)

@JedWatson JedWatson deleted the robots-rock branch December 3, 2015 22:40
@ericelliott
Copy link
Contributor Author

Is there an issue tracking the replacement?

@JedWatson
Copy link
Member

@ericelliott
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants