Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linked variables in newly created items #57

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Lodugh
Copy link
Contributor

@Lodugh Lodugh commented Jun 21, 2023

Now it should be finally fixed. I couldnt think of any other way. Reverted the old commit as well.

@scriptsengineer
Copy link
Member

I analyzed the previous commits and they solved the problem, this pr solves when the creation was already done wrong and placed new items with the same array and dictionaries, I ask you to do the test to know if I'm missing something, I created a database and two items and they have different list already.

@scriptsengineer
Copy link
Member

Update:
Categories work fine, but here properties keep getting created in duplicate.

@Lodugh
Copy link
Contributor Author

Lodugh commented Jun 25, 2023

I analyzed the previous commits and they solved the problem, this pr solves when the creation was already done wrong and placed new items with the same array and dictionaries, I ask you to do the test to know if I'm missing something, I created a database and two items and they have different list already.

The previous commit did solve the problem, but only for newly created items and only as long as the resource doesn't get reloaded. As mentioned in the issue if the value is saved as the global default value of the resource it will be linked to it on the next project load.

What do you mean exactly with "properties keep getting created in duplicate"? I don't have any issues with properties.

@scriptsengineer
Copy link
Member

The creation of categories is normal with your last PR, however the problem still occurs with the dictionaries (I said duplicated wrongly, I meant that new items are taking the dictionary from the other items as the issue presents here), I am analyzing now if not linked with issue #58 i fixed now

I analyzed the previous commits and they solved the problem, this pr solves when the creation was already done wrong and placed new items with the same array and dictionaries, I ask you to do the test to know if I'm missing something, I created a database and two items and they have different list already.

The previous commit did solve the problem, but only for newly created items and only as long as the resource doesn't get reloaded. As mentioned in the issue if the value is saved as the global default value of the resource it will be linked to it on the next project load.

What do you mean exactly with "properties keep getting created in duplicate"? I don't have any issues with properties.

Copy link
Member

@scriptsengineer scriptsengineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for something palliative at the moment.

@scriptsengineer scriptsengineer merged commit f114ff8 into expressobits:main Jun 25, 2023
@Lodugh Lodugh deleted the item_fix branch July 6, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants