chore: update Extism namespace to extism:host/env
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2023-10-20 6:00pm: hey, the tests pass now
- 2023-10-20 11:00pm: hey! we're passing data around
- tomorrow:
- implement host->guest and host->worker->guest calls
- create a wasi
- 2023-10-21 10:40am: stuff all of our internal config into an interface
- I kind of think we want a `wasi: WASI | boolean` flag instead of `useWasi: boolean`
- 2023-10-21 1:09am: update deps
- 2023-10-22 10:51pm: whew! lots of stuff working now! next up: host functions!
- 2023-10-23 2:51pm: okay, I have to do some more major surgery: callcontext needs to
be instantiated per invocation and live canonically on the host
thread
- 2023-10-25 12:40pm: blocks are transferred between the main and background threads
as-needed now. what a ride.
- 2023-10-25 11:08pm: all of the tests from the original deno test suite pass now.
- 2023-10-26 9:57am: we lint!
- 2023-10-26 10:26am: all of the examples work!
- 2023-10-26 12:51pm: add DEVELOPING.md, artifacts tests
this tests transferring data from the host back down to the guest thread where the data exceeds the SAB scratch page length. there's only one bug thus far: firefox gets caught in a Atomics.compareExchange loop.
zshipko
changed the title
extism:host/envextism:host/env
chrisdickinson
force-pushed
the
main
branch
2 times, most recently
from
a425036 to
b093fc0
Compare
Merged
chrisdickinson
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Thanks for sorting out the Haskell/WASI init order & updating the namespaces!
I saw one bug – ttp_request instead of http_request – and a formatting thing in the polyfills, but just format should fix that up. Otherwise this LGTM! Once these are fixed feel free to merge at will!
Co-authored-by: Chris Dickinson <chris@dylibso.com>
Merged
|
Added #26 to run tests, just case something is weird. |
chore: run formatting
|
@nilslice Ah yeah – you might check your Deno version – v1.36 is the minimum supported version. Thanks for PRing that! |
|
@chrisdickinson, indeed I had too old of a Deno installed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: extism/extism#511
GETby default if no method is passed tohttp_request