Skip to content

chore: bump rc #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: bump rc #25

merged 1 commit into from
Nov 13, 2023

Conversation

wikiwong
Copy link
Contributor

@wikiwong wikiwong commented Nov 9, 2023

No description provided.

@chrisdickinson chrisdickinson force-pushed the main branch 2 times, most recently from a425036 to b093fc0 Compare November 10, 2023 00:02
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we should probably also wait for #24 to merge

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@extism/extism",
"version": "1.0.0-rc3",
"version": "1.0.0-rc4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this value is controlled by CI, I'm tempted to set this to 0.0.0-replaced-by-ci, like the python-sdk.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, I just checked the behavior of npm version; it fails if we try to set the version to an existing version – we'll want to set this to 0.0.0-replaced-by-ci.

@chrisdickinson
Copy link
Contributor

@bhelx FWIW, we should be able to land this before #24, since v1.0.0-rc4 has already been released – this PR makes the package.json reflect that! We'll want to cut an rc5 when #24 lands, though.

@chrisdickinson chrisdickinson merged commit 49e33ac into main Nov 13, 2023
@chrisdickinson chrisdickinson deleted the update-version branch November 13, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants