Skip to content

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Jun 12, 2025

I've exposed the CompilerGlobals interface. It's sometimes useful to access when building a SAPI, so it would be helpful for that to be exposed. 🙂

@Qard Qard force-pushed the add-compiler-globals branch from 3e12201 to 173b224 Compare June 12, 2025 17:08
@coveralls
Copy link

coveralls commented Jun 12, 2025

Pull Request Test Coverage Report for Build 15651152136

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 21.345%

Totals Coverage Status
Change from base Build 15650590374: 0.2%
Covered Lines: 841
Relevant Lines: 3940

💛 - Coveralls

@ptondereau
Copy link
Member

I've exposed the CompilerGlobals interface. It's sometimes useful to access when building a SAPI, so it would be helpful for that to be expose. 🙂

By building a SAPI, what do you mean? I'm bit curious 😅

@Qard
Copy link
Contributor Author

Qard commented Jun 13, 2025

I used this to build php-node which embeds PHP as a request handler inside Node.js in a worker thread pool. So not an extension, a server using the SAPI tools. I had to add some extra pieces to make that work and am in the process of backporting those now. 🙂

@Qard Qard force-pushed the add-compiler-globals branch from d4a9620 to e5c60c0 Compare June 14, 2025 10:34
@Xenira Xenira merged commit 11b6a8d into extphprs:master Jun 15, 2025
36 checks passed
@davidcole1340 davidcole1340 mentioned this pull request Jun 15, 2025
@Qard Qard deleted the add-compiler-globals branch June 15, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants