Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use this package in production environment #46

Open
zhangriyueming opened this issue Aug 1, 2018 · 11 comments
Open

Do not use this package in production environment #46

zhangriyueming opened this issue Aug 1, 2018 · 11 comments

Comments

@zhangriyueming
Copy link

  • Boom 1G ram with a 2M xls file.
  • Corrupt data and columns for hundreds KB file.

Always persist original uploaded files

@sergeilem
Copy link
Contributor

sergeilem commented Aug 14, 2018

I think I solved data corruption problem.
Can you test your file with this fork: https://github.com/sergeilem/xls?

@kolkov
Copy link

kolkov commented Jan 23, 2019

Very strange Bug for me to. Also Tested with @sergeilem fork.
In parse result in one column present data from other row and column (before row 83all ok? but after... all very very strange) ((

@sergeilem
Copy link
Contributor

@kolkov, if you can, send me your xls file, I’ll try to fix it.

@kolkov
Copy link

kolkov commented Jan 23, 2019

@kolkov, if you can, send me your xls file, I’ll try to fix it.

Thanks! Ho can I do this?

@sergeilem
Copy link
Contributor

@kolkov, if you can, send me your xls file, I’ll try to fix it.

Thanks! Ho can I do this?

Attach file here or send it to sergeilem at gmail.com.

@kolkov
Copy link

kolkov commented Jan 23, 2019

@sergeilem all files on gmail)

@darren0609
Copy link

Did this end up being solved? I am having the same issue, corruption occurs in files when translating. I am intending to use this to parse files into a DB from an "upload" then report out data.

@kolkov
Copy link

kolkov commented Feb 4, 2019

@darren0609 try "github.com/Towbe/xls" fork. this works for me fine.

@sergeilem
Copy link
Contributor

@kolkov note there is no significant difference between my fork and Towbe's
sergeilem/xls@master...Towbe:master

@kolkov
Copy link

kolkov commented Feb 23, 2019

@sergeilem whats news?

@sergeilem
Copy link
Contributor

Hi @kolkov! I've tried to parse file you sent me with my sergeilem/xls and with tealeg/xlsx, results are equal.

extrame added a commit that referenced this issue Apr 26, 2020
FIX: data corruption while reading, issues #31 #46 #47
John-Saxon pushed a commit to John-Saxon/xls that referenced this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants