Continuation of Continuation of Add search bar at bottom of revlog #506 #672 #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a special logic that make the quit key have priority over all components, unless any popup was visible. This was conflicting with the find commit text input, which happens to not be a popup. Fix that by handling the quit key the same way as any other app key, which appears to already handle popups somehow. Not sure if this change is breaking some logic.
Previously, the filter thread would hold the Mutex locked by the previous thread invocation, and hold a newly created Mutex. I could not see why that would be necessary, instead of just locking the same Mutex. (Also not sure about holding a Mutex at all)
A leftover file, from fixing conflicts conflicts, probably.
Was checking why searching for tag were not working. But `contains_tag` was alright.
AsyncCommitFilterer were assuming that that would be the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work done in #506 and #672.
Closes #429, Closes #449, (But there were already closed by being stale) (part of 1.0 todo list)
I picked from where the last PR was, merged master, and fixed some problems that I found:
quitandhelpkeys don't take priority over typing in the search bar.is_pending.AsyncCommitFilterer::start_filter.AsyncCommitFilterer::filter, fixing some errors.&&(parentheses. This has some non-intuitive limitations, the implementation was sub-optimal, and I am not sure if there is demand for this feature.It changes the following:
(I copied and adapt it from #506)
Go to log tab then press s (suggested in #449), the search box will pop up and be in focus, type to search, the results will appear in the log where the arrow keys can scroll through them. Press esc to close the search box, then esc again to cancel the search and return to all commits.
:s):a):m):t):!)||)&&):c)I followed the checklist:
make checkwithout errors