Continuation of Add search bar at bottom of revlog #506 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Cargo.toml README.md asyncgit/src/sync/commits_info.rs asyncgit/src/sync/mod.rs src/app.rs src/queue.rs src/strings.rs src/tabs/revlog.rs
|
@willir please look into the breaking CI so I can review this. |
|
I hope I fixed the issue. Thanks for pinging me! |
|
@willir please consider running |
Closed
|
@extrawurst Thanks for suggestion about |
no problem. could you rebase again? |
|
I've merged |
11 tasks
|
This PR is really the only thing keeping me on |
|
Hi @heliostatic, I'll try to get back to it this coming weekend. |
|
@willir still planning to get back to this? putting in draft till then |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pull request:
#506
I've fixed the following comments:
Please let me know whether those fixes are enough.
I'm also not sure whether this way is a good way to continue work of the @WizardOhio24, if not, I'd be glad to do it an alternative way.