Re-establish example program build success on GitHub actions Windows runners #505

eyalroz · 2023-04-22T16:43:24Z

When we started building using the CUDA driver (v0.5), Windows build started failing, and I have not managed to restore their success so far. Let's make it happen.

(Actually, I already have, but need to link the relevant commits to this bug, then close it.)

Relevant changes:

Using CMake 3.25's new CUDA::nvtx3 target, which actually works on Windows
Not building examples involving the CUDA profiler (until issue GitHub Windows builds fail due to missing cudaProfiler.h #506 is resolved)
Since MSVC doesn't support C++11, and has library issues when compiling in C++14 mode - compile all the examples as C++17
Tell MSVC not to try to link against the "static" C++ standard library when linking against the static version of NVIDIA's PTX compilation library
Don't try compiling example code which includes cooperative_groups.h, as MSVC 11.7 botches the include search (see issue Build fails with cooperative_groups on GitHub Actions Windows runners with CUDA >= 11.7 #504).

The text was updated successfully, but these errors were encountered:

…filing-related headers in artificial include-everything example code) on Windows, until we settle the missing `cudaProfiler.h` issue

… library's files

…et weird constexpr-correctness complaints

… always

…brary, so let's avoid adding that dependency for MSVC

…ic linking

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Trying to install the cuda_profiler_api subpackage for CUDA versions up to 11.7 * Windows 2022-related minimum version check

… always

…brary, so let's avoid adding that dependency for MSVC

…ic linking

…examples explicitly controllable - with MSVC never using them.

… always

…brary, so let's avoid adding that dependency for MSVC

…ic linking

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Trying to install the cuda_profiler_api subpackage for CUDA versions up to 11.7 * Windows 2022-related minimum version check

…ic linking

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Trying to install the cuda_profiler_api subpackage for CUDA versions up to 11.7 * Windows 2022-related minimum version check

…abling support for half-precision arrays via the preprocessor macro we've built in for that purpose

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Ensuring `cudaProfiler.api` gets installed: * via the `nvprof` subpackage until CUDA 11.7 * via the `cuda_profiler_api` subpackage with CUDA 11.8 and later * Windows 2022-related minimum version check

…bling support for half-precision arrays via the preprocessor macro we've built in for that purpose

…s with CUDA versions before 12, due to trouble locating NVTX headers

…A 10.0 or later (and assume the CMake version is >= 3.25); this helps with locating NVTX includes on Windows

…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)

… library's files

…et weird constexpr-correctness complaints

… always

…brary, so let's avoid adding that dependency for MSVC

…ic linking

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Ensuring `cudaProfiler.api` gets installed: * via the `nvprof` subpackage until CUDA 11.7 * via the `cuda_profiler_api` subpackage with CUDA 11.8 and later * Windows 2022-related minimum version check

…bling support for half-precision arrays via the preprocessor macro we've built in for that purpose

…s with CUDA versions before 12, due to trouble locating NVTX headers

…A 10.0 or later (and assume the CMake version is >= 3.25); this helps with locating NVTX includes on Windows

…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)

… library's files

…et weird constexpr-correctness complaints

… always

…brary, so let's avoid adding that dependency for MSVC

…ic linking

…examples explicitly controllable - with MSVC never using them.

* CUDA versions up to 12.1.1 * Ensuring `cudaProfiler.api` gets installed: * via the `nvprof` subpackage until CUDA 11.7 * via the `cuda_profiler_api` subpackage with CUDA 11.8 and later * Windows 2022-related minimum version check

…s with CUDA versions before 12, due to trouble locating NVTX headers

eyalroz added bug ms-windows Related to the Microsoft Windows operating system build labels Apr 22, 2023

eyalroz self-assigned this Apr 22, 2023

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505, #506: Avoiding profiling examples (and inclusion of pro…

4e60ffb

…filing-related headers in artificial include-everything example code) on Windows, until we settle the missing `cudaProfiler.h` issue

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505, fixes #497: Now using relative include paths within the…

1dc2731

… library's files

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Only build jitify on Windows with C++17, so as not to g…

7024e2e

…et weird constexpr-correctness complaints

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Trying an Update of the windows installer

50a9cb5

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: In the Windows build action script, print CMake version…

4d23d17

… always

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Yet another attempt to satisfy MSVC 2

e71fd47

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: CMake doesn't realse MSVC 16 doesn't have a stdc++fs li…

f012139

…brary, so let's avoid adding that dependency for MSVC

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

4e8dd5d

…ic linking

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

867cfb4

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: In the Windows build action script, print CMake version…

3ee1b6c

… always

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Yet another attempt to satisfy MSVC 2

b26be5a

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: CMake doesn't realse MSVC 16 doesn't have a stdc++fs li…

2aec4c7

…brary, so let's avoid adding that dependency for MSVC

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

4299ab3

…ic linking

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

8b336a7

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: In the Windows build action script, print CMake version…

9dc108c

… always

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Yet another attempt to satisfy MSVC 2

013bf84

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: CMake doesn't realse MSVC 16 doesn't have a stdc++fs li…

615746e

…brary, so let's avoid adding that dependency for MSVC

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

98cb600

…ic linking

eyalroz added a commit that referenced this issue Apr 22, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

79577fa

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue Apr 23, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

0e98118

…ic linking

eyalroz added a commit that referenced this issue Apr 23, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

e05fa85

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue Apr 23, 2023

Regard #505: Trying to avoid the "nv/target not found" issue by dis…

1fd2fdd

…abling support for half-precision arrays via the preprocessor macro we've built in for that purpose

eyalroz added the resolved-on-development label Apr 23, 2023

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

6aaff7d

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue May 1, 2023

Fixes #505: Trying to avoid the "nv/target not found" issue by disa…

877eba4

…bling support for half-precision arrays via the preprocessor macro we've built in for that purpose

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, #506: Not building profiling-related examples on Window…

e662348

…s with CUDA versions before 12, due to trouble locating NVTX headers

eyalroz added a commit that referenced this issue May 1, 2023

Regard #505, fixes #490: Switch to depending on CUDA::nvtx3 for CUD…

da9364c

…A 10.0 or later (and assume the CMake version is >= 3.25); this helps with locating NVTX includes on Windows

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, Fixes #495: Now using the correct output dir specificat…

1a39a8a

…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, fixes #497: Now using relative include paths within the…

21d0952

… library's files

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505: Only build jitify on Windows with C++17, so as not to g…

c934324

…et weird constexpr-correctness complaints

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505: In the Windows build action script, print CMake version…

2d0201a

… always

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505: Yet another attempt to satisfy MSVC 2

b6b5d6a

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505: CMake doesn't realse MSVC 16 doesn't have a stdc++fs li…

f67e502

…brary, so let's avoid adding that dependency for MSVC

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

8213a8d

…ic linking

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

167af65

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue May 1, 2023

Fixes #505: Trying to avoid the "nv/target not found" issue by disa…

bef3687

…bling support for half-precision arrays via the preprocessor macro we've built in for that purpose

eyalroz added a commit that referenced this issue May 1, 2023

Regards #505, #506: Not building profiling-related examples on Window…

1b4cc35

…s with CUDA versions before 12, due to trouble locating NVTX headers

eyalroz added a commit that referenced this issue May 11, 2023

Regard #505, fixes #490: Switch to depending on CUDA::nvtx3 for CUD…

94ae392

…A 10.0 or later (and assume the CMake version is >= 3.25); this helps with locating NVTX includes on Windows

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505, Fixes #495: Now using the correct output dir specificat…

54d2b52

…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505, fixes #497: Now using relative include paths within the…

7e755ec

… library's files

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505: Only build jitify on Windows with C++17, so as not to g…

2ac06e8

…et weird constexpr-correctness complaints

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505: In the Windows build action script, print CMake version…

1b12102

… always

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505: Yet another attempt to satisfy MSVC 2

1b69834

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505: CMake doesn't realse MSVC 16 doesn't have a stdc++fs li…

8d0ee00

…brary, so let's avoid adding that dependency for MSVC

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505: Trying to overcome MSVC complaint about static-vs-dynam…

edd3940

…ic linking

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505, #506: Make the use of the cooperative_groups header in …

3493ca9

…examples explicitly controllable - with MSVC never using them.

eyalroz added a commit that referenced this issue May 11, 2023

Regards #505, #506: Not building profiling-related examples on Window…

34605c8

…s with CUDA versions before 12, due to trouble locating NVTX headers

eyalroz closed this as completed in d56c1e9 May 11, 2023

eyalroz mentioned this issue Dec 30, 2024

Updated cuda-api-wrappers with versions 0.7.1 and 0.8.0 conan-io/conan-center-index#26256

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-establish example program build success on GitHub actions Windows runners #505

Re-establish example program build success on GitHub actions Windows runners #505

eyalroz commented Apr 22, 2023 •

edited

Loading

Re-establish example program build success on GitHub actions Windows runners #505

Re-establish example program build success on GitHub actions Windows runners #505

Comments

eyalroz commented Apr 22, 2023 • edited Loading

eyalroz commented Apr 22, 2023 •

edited

Loading