Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed configuration key to ezpublish from ezplatform #119

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Dec 19, 2019

Travis failure: https://travis-ci.org/ezsystems/ezplatform/jobs/626869956?utm_medium=notification&utm_source=slack

In 3.0 we've changed the main config key from ezpublish to ezplatform. This change can be forward-compatible (ezsystems/ezplatform-core#11), but it requires enabling EzPlatformCoreBundle in AppKernel (new EzSystems\EzPlatformCoreBundle\EzPlatformCoreBundle(),).

This bundle is not enabled by default (see: https://github.com/ezsystems/ezplatform/blob/2.5/app/AppKernel.php), meaning we cannot use that and have to use ezpublish key.

Also changing how the examples are run (they should be run in standard mode, not parallel).

@mnocon mnocon changed the title [WIP] Changed configuration key to ezpublish from ezplatform Changed configuration key to ezpublish from ezplatform Dec 19, 2019
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@micszo micszo merged commit c798904 into 7.0 Dec 19, 2019
@micszo micszo deleted the change-configuration-key branch December 19, 2019 10:55
@lserwatka
Copy link
Member

@mnocon could you make 7.0.3 release?

@mnocon
Copy link
Member Author

mnocon commented Dec 19, 2019

Sure, working on it

@mnocon
Copy link
Member Author

mnocon commented Dec 19, 2019

@lserwatka
Copy link
Member

@mnocon great, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants