-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-30636: Provided forward compatibility for eZ Platform Extension #11
Merged
alongosz
merged 6 commits into
ezsystems:1.0
from
alongosz:ezp-30636-ezplatform-extension
Sep 30, 2019
Merged
EZP-30636: Provided forward compatibility for eZ Platform Extension #11
alongosz
merged 6 commits into
ezsystems:1.0
from
alongosz:ezp-30636-ezplatform-extension
Sep 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ezp-30636-ezplatform-extension
branch
3 times, most recently
from
September 27, 2019 13:38
12f98eb
to
4293586
Compare
alongosz
changed the title
[WiP] EZP-30636: Created eZ Platform Core Bundle and Config Extension
EZP-30636: Created eZ Platform Core Bundle and Config Extension
Sep 27, 2019
alongosz
force-pushed
the
ezp-30636-ezplatform-extension
branch
from
September 27, 2019 15:13
4293586
to
81895a5
Compare
1 task
alongosz
force-pushed
the
ezp-30636-ezplatform-extension
branch
from
September 29, 2019 16:47
81895a5
to
3544de2
Compare
alongosz
changed the title
EZP-30636: Created eZ Platform Core Bundle and Config Extension
EZP-30636: Provided forward compatibility for eZ Platform Extension
Sep 29, 2019
alongosz
force-pushed
the
ezp-30636-ezplatform-extension
branch
from
September 30, 2019 09:01
3544de2
to
7508f87
Compare
alongosz
requested review from
Nattfarinn,
adamwojs,
bdunogier,
lserwatka,
mikadamczyk,
pawbuj,
SylvainGuittard,
ViniTou and
webhdx
September 30, 2019 09:05
webhdx
approved these changes
Sep 30, 2019
ViniTou
approved these changes
Sep 30, 2019
adamwojs
requested changes
Sep 30, 2019
src/EzPlatformCoreBundle/bundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
Sep 30, 2019
This is a workaround to avoid copying all the code from EzPublishCoreBundle at once. It allows using "ezplatform" as a root node for the configuration w/o defining that configuration. Validation is still done by ezpublish extension.
alongosz
force-pushed
the
ezp-30636-ezplatform-extension
branch
from
September 30, 2019 13:06
1254825
to
9c97d3f
Compare
alongosz
added a commit
that referenced
this pull request
Sep 30, 2019
Squashed commit of the following: commit 9c97d3f Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Fri Sep 27 15:28:18 2019 +0200 [Symfony] Prepended ezplatform configuration to ezpublish extension This is a workaround to avoid copying all the code from EzPublishCoreBundle at once. It allows using "ezplatform" as a root node for the configuration w/o defining that configuration. Validation is still done by ezpublish extension. commit f55ad2b Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Wed Sep 25 23:28:37 2019 +0200 [Symfony] Created eZ Platform Core Bundle, Extension, and Configuration commit a932385 Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Wed Sep 25 23:25:46 2019 +0200 [Tests] Created EzPlatformCoreBundle test suite commit cc5d00c Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Wed Sep 25 22:54:17 2019 +0200 [Composer] Added EzPlatformCoreBundle namespace to autoloader commit 1d4e610 Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Wed Sep 25 21:29:30 2019 +0200 [Travis] Added PHPUnit unit tests job commit ed7dcff Author: Andrew Longosz <alongosz@users.noreply.github.com> Date: Wed Sep 25 21:14:36 2019 +0200 [Tests] Created initial PHPUnit tests setup
1 task
mnocon
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me, on v2 with ezplatform
and ezpublish
config prefixes and on v3 with ezplatform
one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0
for eZ Platformv2.5.x
LTS and3.0@beta2
This PR provides forward compatibility with eZ Platform 3.0 by means of eZ Platform Core Bundle and its Extension, so the Developers and Maintainers are able to prefix their eZ Platform configuration with
ezplatform:
instead of
ezpublish:
Current implementation simply prepends
ezplatform
configuration toezpublish
extension. This by no means is a complete solution. It's rather a workaround to simplify migration.For eZ Platform 3.0 we plan to provide fully functional
EzPlatformCoreBundle
which registersezplatform
extension and replacesEzPublishCoreBundle
andezpublish
extension.I still believe this is a good way to go, even if it is a workaround. I took into the account suggestions from the internal Sprint Demo and targeted it for eZ Platform 2.5.x LTS so that PR provides more significant value.
Open question
Should we drop "Core" from the Bundle and Extension name? So it's just// Internal Sync: No.EzPlatformBundle
andEzPlatformExtension
?Doc
To use
ezplatform
instead ofezpublish
in their 2.5.xezplatform.yml
configuration files, the Developers must enable theEzSystems\EzPlatformCoreBundle\EzPlatformCoreBundle
in their Kernel.v2.5
app/AppKernel.php
:v3.0
config/bundles.php
:QA
ezplatform
extension (replacingezpublish
withezplatform
inezplatform.yml
(you could use the alongosz:ezp-30636-ezplatform-extension branch),ezpublish
configuration.TODO
ezpublish
extension with config fromezplatform
extension.