Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30636: Enabled eZ Platform Bundle #463

Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Sep 30, 2019

Question Answer
JIRA issue EZP-30636
Bug/Improvement no
New feature yes
Target version eZ Platform v3.0
BC breaks yes
Tests pass TBD
Doc needed yes

This PR enables eZ Platform Core Bundle and uses ezplatform extension instead of ezpublish.

TODO:

@alongosz alongosz force-pushed the ezp-30636-ezplatform-extension-v3 branch from cd05af0 to 3f820ba Compare September 30, 2019 15:58
@alongosz alongosz changed the title [REBASE REQUIRED] EZP-30636: Enabled eZ Platform Bundle EZP-30636: Enabled eZ Platform Bundle Sep 30, 2019
@alongosz alongosz merged commit e116dd4 into ezsystems:master Sep 30, 2019
@alongosz alongosz deleted the ezp-30636-ezplatform-extension-v3 branch September 30, 2019 18:28
@emodric
Copy link
Contributor

emodric commented Oct 2, 2019

@alongosz In my limited tests on eZ Platform v3, this breaks our bundles if we switch to ezplatform extension. We have some eZ related config under ezpublish key like image aliases, field template overrides and so on.

If we prepend the bundle config to ezplatform extension instead of ezpublish, some of the config breaks, most notably, field template overrides.

I didn't test this, but this could maybe happen if our bundle is activated after the EzPlatformCoreBundle, meaning our prepending would execute after EzPlatformCoreExtension is done, which means it wouldn't get prepended to ezpublish namespace.

@emodric
Copy link
Contributor

emodric commented Oct 2, 2019

I didn't test this, but this could maybe happen if our bundle is activated after the EzPlatformCoreBundle, meaning our prepending would execute after EzPlatformCoreExtension is done, which means it wouldn't get prepended to ezpublish namespace.

It seems that this is indeed the case. If I move our bundle before the EzPlatformCoreBundle bundle, then it works fine. This unfortunately is not the solution, since there might be other code that depends on having the 3rd party bundles after eZ core bundles.

@alongosz
Copy link
Member Author

alongosz commented Oct 2, 2019

I didn't test this, but this could maybe happen if our bundle is activated after the EzPlatformCoreBundle, meaning our prepending would execute after EzPlatformCoreExtension is done, which means it wouldn't get prepended to ezpublish namespace.

It seems that this is indeed the case. If I move our bundle before the EzPlatformCoreBundle bundle, then it works fine. This unfortunately is not the solution, since there might be other code that depends on having the 3rd party bundles after eZ core bundles.

This is known issue being documented via https://github.com/ezsystems/developer-documentation/pull/786/files#diff-c117f5035fbf4b21031830a1fb9927baR108-R111. Unfortunately it's a technical limitation due to how Symfony prepends configuration. Once EZP-30990 is resolved properly, prepending should behave correctly.

@emodric
Copy link
Contributor

emodric commented Oct 2, 2019

Alright, good to know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants