Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31837: Creating an additional Content Location does not respect Content visibility #107

Conversation

pspanja
Copy link
Contributor

@pspanja pspanja commented Sep 10, 2020

Question Answer
JIRA issue EZP-31837
Type bug
Target eZ Platform version v3.1.3
BC breaks no
Tests pass yes
Doc needed no

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@pspanja pspanja changed the title EZP-31837: implement test EZP-31837: Creating an additional Content Location does not repect Content visibility Sep 10, 2020
@adamwojs adamwojs added the Bug Something isn't working label Sep 15, 2020
@ViniTou
Copy link
Contributor

ViniTou commented Sep 16, 2020

Should it not target 1.1 at least?
@adamwojs

@adamwojs
Copy link
Member

Should it not target 1.1 at least?

You are right. AFAIR content hide/reveal was part of the eZ Platform 2.5 so probably bug is there as well.

@pspanja
Copy link
Contributor Author

pspanja commented Sep 18, 2020

OK, do let me know where exactly you want this.

@lserwatka
Copy link
Member

Could you open this against ezpublish-kernel/7.5 branch. We will run QA on 2.5.x and 3.1.x.

@pspanja
Copy link
Contributor Author

pspanja commented Sep 18, 2020

OK, will do. I also added a fix for incorrect docs of Location::$invisible property in 4acc1d4, as tested here:

$this->assertTrue($locations[0]->invisible);

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lserwatka
Copy link
Member

OK, will do. I also added a fix for incorrect docs of Location::$invisible property in 4acc1d4, as tested here:

$this->assertTrue($locations[0]->invisible);

Looks good. Thank you

@pspanja pspanja changed the title EZP-31837: Creating an additional Content Location does not repect Content visibility EZP-31837: Creating an additional Content Location does not respect Content visibility Sep 18, 2020
@pspanja
Copy link
Contributor Author

pspanja commented Sep 18, 2020

Opened ezsystems/ezpublish-kernel#3066

@adamwojs
Copy link
Member

Closed in favor of ezsystems/ezpublish-kernel#3066 (changes will be merged up)

@adamwojs adamwojs closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants