Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31837: Creating an additional Content Location does not repect Content visibility #3066

Merged
merged 4 commits into from
Oct 5, 2020
Merged

EZP-31837: Creating an additional Content Location does not repect Content visibility #3066

merged 4 commits into from
Oct 5, 2020

Conversation

pspanja
Copy link
Contributor

@pspanja pspanja commented Sep 18, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31837
Type bug
Target eZ Platform version v7.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@pspanja pspanja mentioned this pull request Sep 18, 2020
Closed
4 tasks
@ViniTou ViniTou changed the title EZP-31837: implement test EZP-31837: Creating an additional Content Location does not repect Content visibility Sep 18, 2020
@ViniTou ViniTou requested a review from adamwojs September 18, 2020 09:00
alongosz
alongosz requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor CS remarks:

eZ/Publish/API/Repository/Tests/LocationServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/LocationServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/LocationServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/LocationServiceTest.php Outdated Show resolved Hide resolved
@pspanja pspanja force-pushed the EZP-31837_create_location_content_visibility branch from f280765 to c5536b0 Compare September 19, 2020 14:18
@adamwojs adamwojs requested a review from alongosz September 21, 2020 06:43
@micszo micszo self-assigned this Oct 2, 2020
micszo
micszo approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.14 & v3.1.3 with diff with PAPI.

@micszo micszo removed their assignment Oct 5, 2020
@lserwatka lserwatka merged commit 42fee31 into ezsystems:7.5 Oct 5, 2020
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

alongosz commented Oct 6, 2020

Merged into ezplatform-kernel:1.1 as ezsystems/ezplatform-kernel@42fee31, via ezsystems/ezplatform-kernel@46bd2ea and up to ezplatform-kernel:master via ezsystems/ezplatform-kernel@8c8e287.

Thank you @pspanja 🎉

@pspanja pspanja deleted the EZP-31837_create_location_content_visibility branch October 6, 2020 09:15
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pspanja @lserwatka @alongosz @adamwojs @micszo @ViniTou