[SF4] Implemented factory for IndexingDepthProvider #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
sf4-fix-indexing-depth-provider
branch
2 times, most recently
from
73877f5 to
06240f9
Compare
Symfony 4 no longer allows using private services in DIC @=service expressions so we need to provide factory instead.
alongosz
force-pushed
the
sf4-fix-indexing-depth-provider
branch
from
06240f9 to
afa4c21
Compare
adamwojs
approved these changes
Jun 18, 2019
webhdx
approved these changes
Jun 24, 2019
|
Merging to unblock failing RichText integration tests |
6 tasks
alongosz
added a commit
that referenced
this pull request
Jan 31, 2020
* Added MaxDepth parameter for Content and Location FullText Criteria * Set default max depth=2 for integration tests * [SF4 forward compatibility] Implemented factory for IndexingDepthProvider (back-ported from #141) * Refactored max-depth parameter providing Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.0 (master)for eZ Platformv3.0Symfony 4 no longer allows using private services in DIC
@=serviceexpressions so we need to providefactory instead.
TODO: