EZP-31226: Added MaxDepth parameter for query location criterion and set default max depth=2 for integration tests #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alongosz
requested changes
Jan 22, 2020
michal-myszka
changed the title
michal-myszka
changed the title
adamwojs
approved these changes
Jan 24, 2020
alongosz
approved these changes
Jan 27, 2020
after talk with the @adamwojs this CI fail is not connected with my PR |
Yes, CI failure is not related to PR changes. I will take care of it. |
|
Ok, you can move this to QA. |
micszo
approved these changes
Jan 31, 2020
Symfony 4 no longer allows using private services in DIC @=service expressions so we need to provide factory instead.
alongosz
changed the title
alongosz
pushed a commit
to ezsystems/ezpublish-kernel
that referenced
this pull request
Jan 31, 2020
Added test coverage for the changes from ezsystems/ezplatform-solr-search-engine#165.
|
Merged up to 2.0 as a9b568b and up to master as bc2f8dc. We'll need a follow-up for Solr tests in Kernel as the scoring changed and I had to temporarily disable one of them on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.7for bug fixes or improvements (on existing features)Solution for reported bug:
https://jira.ez.no/browse/EZP-31226
Fixed missing "depth" parameters and added new test for fulltext search for embed content
Changes also in ezpublish-kernel: ezsystems/ezpublish-kernel#2922
TODO:
$ composer fix-cs).