Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Composer] Added conflict with lexik/jwt-authentication-bundle 2.12.0 #662

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented Jun 24, 2021

Travis failure: https://travis-ci.com/github/ezsystems/ezplatform-page-builder/jobs/518410065#L2576

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  PHP Fatal error:  Class EzSystems\EzPlatformPageBuilder\Security\EditorialMode\TokenManager contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Lexik\Bundle\JWTAuthenticationBundle\Services\JWTTokenManagerInterface::decodeFromJsonWebToken) in /var/www/vendor/ezsystems/ezplatform-page-builder/src/lib/Security/EditorialMode/TokenManager.php on line 24
!!  Symfony\Component\ErrorHandler\Error\FatalError {#10767
!!    -error: array:4 [
!!      "type" => 1
!!      "message" => "Class EzSystems\EzPlatformPageBuilder\Security\EditorialMode\TokenManager contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Lexik\Bundle\JWTAuthenticationBundle\Services\JWTTokenManagerInterface::decodeFromJsonWebToken)"
!!      "file" => "/var/www/vendor/ezsystems/ezplatform-page-builder/src/lib/Security/EditorialMode/TokenManager.php"
!!      "line" => 24
!!    ]
!!    #message: "Error: Class EzSystems\EzPlatformPageBuilder\Security\EditorialMode\TokenManager contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Lexik\Bundle\JWTAuthenticationBundle\Services\JWTTokenManagerInterface::decodeFromJsonWebToken)"
!!    #code: 0
!!    #file: "./vendor/ezsystems/ezplatform-page-builder/src/lib/Security/EditorialMode/TokenManager.php"
!!    #line: 24
!!  }
!!  
Script @auto-scripts was called via post-install-cmd

It's caused by the latest release in LexikJWTAuthenticationBundle, please see lexik/LexikJWTAuthenticationBundle#872 (comment) for more information.

In theory we could only limit the dependency for ezplatform-ee, as this is the project where it breaks for us, but I think it's better to use the same bundle version across editions to avoid complications.

@adamwojs adamwojs merged commit a4d0d6f into 3.2 Jun 24, 2021
@adamwojs adamwojs deleted the add-conflict-lexik branch June 24, 2021 06:45
@adamwojs
Copy link
Member

Could you please merge up changes @mnocon?

@Steveb-p
Copy link
Contributor

Shouldn't this also include all the future versions, up from 2.12.0?

@mnocon
Copy link
Member Author

mnocon commented Jun 24, 2021

@Steveb-p please see the discussion I've linked - the BC break should be removed in the next bugfix version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants