Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conflict rule for lexik/jwt-authentication-bundle #663

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Remove conflict rule for lexik/jwt-authentication-bundle #663

merged 1 commit into from
Jul 7, 2021

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Jun 27, 2021

Reverts #662. The BC break has been fixed in 2.12.1.
Note that you may want to implement the new JWTTokenManagerInterface#parse() method in your TokenManager implementation as it will be mandatory in 3.0.

@adamwojs adamwojs requested review from a team June 28, 2021 06:13
@mikadamczyk mikadamczyk requested a review from a team June 28, 2021 06:20
@ciastektk ciastektk requested a review from a team June 28, 2021 06:42
@Steveb-p
Copy link
Contributor

I'm unsure if this removal is necessary - we are targeting a specific version, since a fix was expected. This conflict entry will allow 2.12.1 to be installed normally, while preventing 2.12.0.

@chalasr
Copy link
Contributor Author

chalasr commented Jun 28, 2021

Given that composer always install the latest version when a range is required (or lowest with —prefer-lowest) and that requiring a fixed version is not common (if not discouraged), it’s safe to remove it.
Maintaining such a conflict rule is not necessary.

Steveb-p
Steveb-p approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not doing lowest dependency check (yet), so 👍.

@chalasr
Copy link
Contributor Author

chalasr commented Jul 7, 2021

Is there anything else I can do to help moving forward here?

mnocon
mnocon approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@adamwojs adamwojs merged commit 59aa398 into ezsystems:master Jul 7, 2021
@chalasr chalasr deleted the rm-lexik-conflict branch July 7, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@mnocon mnocon mnocon approved these changes

@webhdx webhdx webhdx approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chalasr @Steveb-p @adamwojs @mikadamczyk @ciastektk @webhdx @mnocon @ViniTou