Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised easter animation #305

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

klem-bot-delta
Copy link
Contributor

  • Switched beerflakes from GIFs to CSS animations
  • Removed redundant JS code by using a ternary
  • Switched cursed beerflakes to using a modifier CSS class instead of a dedicated function
  • Moved some CSS styles from JS to the CS

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #305 (ebe19d4) into next (46d63d6) will increase coverage by 28.54%.
The diff coverage is n/a.

❗ Current head ebe19d4 differs from pull request most recent head cc88b31. Consider uploading reports for the commit cc88b31 to get more accurate results

@@             Coverage Diff             @@
##             next     #305       +/-   ##
===========================================
+ Coverage   53.90%   82.44%   +28.54%     
===========================================
  Files          33       31        -2     
  Lines        4508     2518     -1990     
  Branches      265      182       -83     
===========================================
- Hits         2430     2076      -354     
+ Misses       2028      412     -1616     
+ Partials       50       30       -20     

see 33 files with indirect coverage changes

@atjn
Copy link
Contributor

atjn commented Oct 13, 2022

I am working on some more optimizations to the CSS and JS for the entire frontend. Some of my optimizations are almost identical to the ones in this PR. Is it possible to get this merged, or alternatively, have your blessing to duplicate these changes in my PR?

Copy link

@Nielswps Nielswps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to have the optimizations merged before easter 🐣

Copy link
Contributor

@JakobTopholt JakobTopholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JakobTopholt JakobTopholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm

Copy link
Contributor

@Nobogo Nobogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My only comment is some of the image files possibly aren't being used.

@krestenlaust krestenlaust merged commit e581544 into f-klubben:next Oct 18, 2023
@krestenlaust
Copy link
Member

krestenlaust commented Oct 18, 2023

Merged before easter 👍

EDIT: Reverted in favor of #329

krestenlaust added a commit that referenced this pull request Oct 20, 2023
falkecarlsen pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants