-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimised easter animation #305
Conversation
klem-bot-delta
commented
Apr 27, 2022
- Switched beerflakes from GIFs to CSS animations
- Removed redundant JS code by using a ternary
- Switched cursed beerflakes to using a modifier CSS class instead of a dedicated function
- Moved some CSS styles from JS to the CS
Codecov Report
@@ Coverage Diff @@
## next #305 +/- ##
===========================================
+ Coverage 53.90% 82.44% +28.54%
===========================================
Files 33 31 -2
Lines 4508 2518 -1990
Branches 265 182 -83
===========================================
- Hits 2430 2076 -354
+ Misses 2028 412 -1616
+ Partials 50 30 -20 |
I am working on some more optimizations to the CSS and JS for the entire frontend. Some of my optimizations are almost identical to the ones in this PR. Is it possible to get this merged, or alternatively, have your blessing to duplicate these changes in my PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to have the optimizations merged before easter 🐣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My only comment is some of the image files possibly aren't being used.
Merged before easter 👍 EDIT: Reverted in favor of #329 |
This reverts commit e581544.